If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

TypeError: environment can only contain strings

RESOLVED FIXED in Firefox 54

Status

()

Core
mach
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: evilpie, Assigned: blassey)

Tracking

unspecified
mozilla54
x86
Windows 10
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
When passing --debugger=devenv.exe on Windows, I get this following error:
TypeError: environment can only contain strings

It's caused by mozrunner/base/runner.py: self.process_handler = subprocess.Popen(cmd, env=self.env). self.env contains one value that is of type unicode instead of str.

MOZ_GMP_PATH <type 'str'> c:/Users/tom/mozilla-inbound/obj-x86_64-pc-mingw32\dist\bin\gmp-fake\1.0;c:/Users/tom/mozilla-inbound/obj-x86_64-pc-mingw32\dist\bin\gmp-clearkey\0.1;c:/Users/tom/mozilla-inbound/obj-x86_64-pc-mingw32\dist\bin\gmp-fakeopenh264\1.0 <type 'unicode'>
(Assignee)

Comment 1

9 months ago
Created attachment 8828438 [details] [diff] [review]
unicode_runner.patch

I hit this, this patch uses the work around that we've landed in some other python files
Assignee: nobody → blassey.bugs
Attachment #8828438 - Flags: review?(gps)
Attachment #8828438 - Flags: review?(gps) → review+

Comment 2

9 months ago
Pushed by blassey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35ee729f6f1e
TypeError: environment can only contain strings, convert environment from unicode before passing to popen r=gps
sorry had to back this out for a flake8 test failure like https://treeherder.mozilla.org/logviewer.html#?job_id=71162125&repo=mozilla-inbound
Flags: needinfo?(blassey.bugs)

Comment 4

9 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79363f8a5622
Backed out changeset 35ee729f6f1e for flake8 test failure
(Assignee)

Updated

9 months ago
Flags: needinfo?(blassey.bugs)

Comment 5

9 months ago
Pushed by blassey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61dec5fbbb25
TypeError: environment can only contain strings, convert environment from unicode before passing to popen r=gps

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61dec5fbbb25
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.