1295699 - TypeError: environment can only contain strings

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Tom S [:evilpie]]

When passing --debugger=devenv.exe on Windows, I get this following error:
TypeError: environment can only contain strings

It's caused by mozrunner/base/runner.py: self.process_handler = subprocess.Popen(cmd, env=self.env). self.env contains one value that is of type unicode instead of str.

MOZ_GMP_PATH <type 'str'> c:/Users/tom/mozilla-inbound/obj-x86_64-pc-mingw32\dist\bin\gmp-fake\1.0;c:/Users/tom/mozilla-inbound/obj-x86_64-pc-mingw32\dist\bin\gmp-clearkey\0.1;c:/Users/tom/mozilla-inbound/obj-x86_64-pc-mingw32\dist\bin\gmp-fakeopenh264\1.0 <type 'unicode'>

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: unicode_runner.patch

I hit this, this patch uses the work around that we've landed in some other python files

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35ee729f6f1e
TypeError: environment can only contain strings, convert environment from unicode before passing to popen r=gps

Comment 3

[Carsten Book [:Tomcat]]

sorry had to back this out for a flake8 test failure like https://treeherder.mozilla.org/logviewer.html#?job_id=71162125&repo=mozilla-inbound

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79363f8a5622
Backed out changeset 35ee729f6f1e for flake8 test failure

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61dec5fbbb25
TypeError: environment can only contain strings, convert environment from unicode before passing to popen r=gps

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/61dec5fbbb25