Closed
Bug 1295739
Opened 8 years ago
Closed 8 years ago
Make JSRuntime::ownerThread_ a js::Thread::Id instead of void*
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
2.80 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8781697 -
Flags: review?(terrence)
|
|
Assignee | |
Updated•8 years ago
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8781697 [details] [diff] [review] Make JSRuntime::ownerThread_ a js::Thread::Id instead of void* Review of attachment 8781697 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/Runtime.cpp @@ +167,5 @@ > numCompartments(0), > localeCallbacks(nullptr), > defaultLocale(nullptr), > defaultVersion_(JSVERSION_DEFAULT), > + ownerThread_(), We should just initialize the thread owner here if possible and assert in init that we were called called on the same thread. I think anything else is probably a bug.
Attachment #8781697 -
Flags: review?(terrence) → review+
Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6100b7cdc384 Make JSRuntime::ownerThread_ a js::Thread::Id instead of void*; r=terrence
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6100b7cdc384
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•