jslock.h is dead, long live jsnspr.h

RESOLVED FIXED in Firefox 51

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

This commit makes the following changes:

* Removed unnecessary includes of jslock.h from files that are using
  js/src/thread/* primitives now.

* Removed includes of prcvar.h, prlock.h, and prthread.h in jslock.h.

* Renamed jslock.h to jsnspr.h since its only remaining utility is to either
  wrap the few NSPR headers we still use, or alternatively include the
  vm/PosixNSPR.h shim instead if JS_POSIX_NSPR is defined.
Created attachment 8781699 [details] [diff] [review]
jslock.h is dead, long live jsnspr.h
Attachment #8781699 - Flags: review?(terrence)
Assignee: nobody → nfitzgerald
Blocks: 956899
Status: NEW → ASSIGNED
Depends on: 1275749
Comment on attachment 8781699 [details] [diff] [review]
jslock.h is dead, long live jsnspr.h

Review of attachment 8781699 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ \o/ \o/
Attachment #8781699 - Flags: review?(terrence) → review+

Comment 3

a year ago
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b6f61ea7594
jslock.h is dead, long live jsnspr.h; r=terrence

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b6f61ea7594
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.