Closed
Bug 1295741
Opened 8 years ago
Closed 8 years ago
jslock.h is dead, long live jsnspr.h
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
21.18 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
This commit makes the following changes: * Removed unnecessary includes of jslock.h from files that are using js/src/thread/* primitives now. * Removed includes of prcvar.h, prlock.h, and prthread.h in jslock.h. * Renamed jslock.h to jsnspr.h since its only remaining utility is to either wrap the few NSPR headers we still use, or alternatively include the vm/PosixNSPR.h shim instead if JS_POSIX_NSPR is defined.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8781699 -
Flags: review?(terrence)
|
|
Assignee | |
Updated•8 years ago
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8781699 [details] [diff] [review] jslock.h is dead, long live jsnspr.h Review of attachment 8781699 [details] [diff] [review]: ----------------------------------------------------------------- \o/ \o/ \o/
Attachment #8781699 -
Flags: review?(terrence) → review+
Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4b6f61ea7594 jslock.h is dead, long live jsnspr.h; r=terrence
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4b6f61ea7594
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•