Closed Bug 1295751 Opened 8 years ago Closed 8 years ago

Stop running autoconf in autospider.py

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(2 files, 1 obsolete file)

With the way things are reshuffled currently, it looks like the only reason to run autoconf is to update the timestamp. But it's a nuisance since the binary name is inconsistent, and it gets tangled up with Windows filenames (shell vs python), and apparently the build peers do not want it to happen anyway.
MozReview-Commit-ID: Joifn5l6ASp
Attachment #8781710 - Flags: review?(mh+mozilla)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
MozReview-Commit-ID: 9COvbxsmRf2
Attachment #8781711 - Flags: review?(mh+mozilla)
Comment on attachment 8781711 [details] [diff] [review]
Stop running autoconf in autospider.py

Review of attachment 8781711 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/devtools/automation/autospider.py
@@ +254,5 @@
>  if not args.nobuild:
>      CONFIGURE_ARGS += ' --enable-nspr-build'
>      CONFIGURE_ARGS += ' --prefix={OBJDIR}/dist'.format(OBJDIR=POBJDIR)
> +    pconfigure = posixpath.join(PDIR.js_src, 'configure')
> +    run_command(['sh', '-c', 'if [ ! -x {cfg} ]; then cp {cfg}.in {cfg} && chmod +x {cfg}; fi'.format(cfg=pconfigure)])

Please do this in python rather than shelling it out. (using os.path.exists, shutil.copyfile and os.chmod)
Attachment #8781711 - Flags: review?(mh+mozilla)
Comment on attachment 8781710 [details] [diff] [review]
Make it possible to copy configure.in to configure

Review of attachment 8781710 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1,2 @@
> +#!/bin/sh
> +divert()#!/bin/sh

smart, but I found something even better.
Attachment #8781710 - Flags: review?(mh+mozilla)
Attachment #8781710 - Attachment is obsolete: true
Attachment #8781808 - Flags: review?(gps)
Attachment #8781808 - Flags: review?(gps) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/54cf74de41df
Make it possible to copy configure.in to configure. r=gps
https://hg.mozilla.org/integration/mozilla-inbound/rev/02b22e48fee6
Stop running autoconf in autospider.py, r=glandium
https://hg.mozilla.org/mozilla-central/rev/54cf74de41df
https://hg.mozilla.org/mozilla-central/rev/02b22e48fee6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.