Re-name the `condition` argument to pkg_check_modules to `when`, for consistency
RESOLVED
FIXED
in Firefox 51
Status
People
(Reporter: cmanchester, Assigned: cmanchester)
Tracking
(Blocks 1 bug)
Firefox Tracking Flags
(firefox51 fixed)
Details
Attachments
(2 attachments)
... and use the argument name in more places, for clarity.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8781754 [details] Bug 1295784 - Use `when` instead of `condition` as an argument name in Python configure's pkg_check_modules for consistency. https://reviewboard.mozilla.org/r/72100/#review69714
Attachment #8781754 -
Flags: review?(mh+mozilla) → review+
|
|
||
Comment 4•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8781755 [details] Bug 1295784 - Use the argument name for `when` when passing it to Python configure's pkg_check_modules. https://reviewboard.mozilla.org/r/72102/#review69718
Attachment #8781755 -
Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aa9e6ab2f145 Use `when` instead of `condition` as an argument name in Python configure's pkg_check_modules for consistency. r=glandium https://hg.mozilla.org/integration/mozilla-inbound/rev/1f16e23b6885 Use the argument name for `when` when passing it to Python configure's pkg_check_modules. r=glandium
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aa9e6ab2f145 https://hg.mozilla.org/mozilla-central/rev/1f16e23b6885
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
| Comment hidden (Intermittent Failures Robot) |
|
||
Updated•Last year
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•