Closed
Bug 1295784
Opened 9 years ago
Closed 9 years ago
Re-name the `condition` argument to pkg_check_modules to `when`, for consistency
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
... and use the argument name in more places, for clarity.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•9 years ago
|
||
mozreview-review |
Comment on attachment 8781754 [details]
Bug 1295784 - Use `when` instead of `condition` as an argument name in Python configure's pkg_check_modules for consistency.
https://reviewboard.mozilla.org/r/72100/#review69714
Attachment #8781754 -
Flags: review?(mh+mozilla) → review+
Comment 4•9 years ago
|
||
mozreview-review |
Comment on attachment 8781755 [details]
Bug 1295784 - Use the argument name for `when` when passing it to Python configure's pkg_check_modules.
https://reviewboard.mozilla.org/r/72102/#review69718
Attachment #8781755 -
Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa9e6ab2f145
Use `when` instead of `condition` as an argument name in Python configure's pkg_check_modules for consistency. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f16e23b6885
Use the argument name for `when` when passing it to Python configure's pkg_check_modules. r=glandium
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/aa9e6ab2f145
https://hg.mozilla.org/mozilla-central/rev/1f16e23b6885
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•