1295784 - Re-name the `condition` argument to pkg_check_modules to `when`, for consistency

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

... and use the argument name in more places, for clarity.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1295784 - Use `when` instead of `condition` as an argument name in Python configure's pkg_check_modules for consistency.

Review commit: https://reviewboard.mozilla.org/r/72100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72100/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1295784 - Use the argument name for `when` when passing it to Python configure's pkg_check_modules.

Review commit: https://reviewboard.mozilla.org/r/72102/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72102/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8781754 [details]
Bug 1295784 - Use `when` instead of `condition` as an argument name in Python configure's pkg_check_modules for consistency.

https://reviewboard.mozilla.org/r/72100/#review69714

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8781755 [details]
Bug 1295784 - Use the argument name for `when` when passing it to Python configure's pkg_check_modules.

https://reviewboard.mozilla.org/r/72102/#review69718

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa9e6ab2f145
Use `when` instead of `condition` as an argument name in Python configure's pkg_check_modules for consistency. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f16e23b6885
Use the argument name for `when` when passing it to Python configure's pkg_check_modules. r=glandium

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa9e6ab2f145
https://hg.mozilla.org/mozilla-central/rev/1f16e23b6885

Comment 7

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 5

Platform breakdown:
* windows7-32: 3
* windows8-64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295784&startday=2016-08-15&endday=2016-08-21&tree=all