Closed Bug 1295786 Opened 8 years ago Closed 8 years ago

nestegg: value is outside the range of representable values of type 'unsigned long' in [@nestegg_duration] nestegg.c:2080

Categories

(Core :: Audio/Video: Playback, defect, P1)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox51 --- affected

People

(Reporter: tsmith, Assigned: kinetik)

References

Details

(Keywords: testcase)

Attachments

(2 files)

test_case.webm
272 bytes, video/webm
Details
patch
44 bytes, text/x-github-pull-request
rillian
: review+
Details | Review
Attached video test_case.webm — 
I found this while fuzzing nestegg commit 9b7b79412432df3c3f996b42eac19ce60d56ee48

Looks similar to bug 1294527.

Run the attached test case in a Undefined Behavior Sanitizer (UBSan) build to trigger the following error:

src/nestegg.c:2085:7: runtime error: value -nan is outside the range of representable values of type 'unsigned long'
    #0 0x4f28b1 in nestegg_duration src/nestegg.c:2085:7
    #1 0x4ea228 in main test/test.c:112:7
    #2 0x7fa1058ae82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #3 0x4188c8 in _start (/home/ubuntu/build/build/test+0x4188c8)
Attached file patch — 
Test for NaN too.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #8781804 - Flags: review?(giles)
Attachment #8781804 - Flags: review?(giles) → review+
Depends on: 1296988
Can we land the fix here? We're trying to close the P1 bugs.
Flags: needinfo?(kinetik)
Fixed by bug 1296988.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(kinetik)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: