Closed Bug 1295811 Opened 4 years ago Closed 4 years ago

Skip various configure checks when compile environment not configured

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(2 files)

No description provided.
Comment on attachment 8781773 [details]
Bug 1295811 - Only run allocator checks when compile environment needed;

https://reviewboard.mozilla.org/r/72106/#review69720
Attachment #8781773 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8781774 [details]
Bug 1295811 - Remove check for __attribute__(aligned());

https://reviewboard.mozilla.org/r/72108/#review69722

::: old-configure.in:3245
(Diff revision 1)
>           break;
>         fi
>       done
>         CFLAGS="${CFLAGS_save}"])
>  if test "${ac_cv_c_attribute_aligned}" != "0"; then
>    AC_DEFINE_UNQUOTED([ATTRIBUTE_ALIGNED_MAX],

Nothing is using ATTRIBUTE_ALIGNED_MAX since bug 556455, 6 years ago. Please remove the whole thing.
Attachment #8781774 - Flags: review?(mh+mozilla)
Comment on attachment 8781774 [details]
Bug 1295811 - Remove check for __attribute__(aligned());

https://reviewboard.mozilla.org/r/72108/#review69726
Attachment #8781774 - Flags: review?(mh+mozilla) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d227c4f173d
Only run allocator checks when compile environment needed; r=glandium
https://hg.mozilla.org/integration/autoland/rev/f904a6f393b6
Remove check for __attribute__(aligned()); r=glandium
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46132442a61f
Check COMPILE_ENVIRONMENT instead of SKIP_COMPILER_CHECKS; r=glandium
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.