Closed Bug 1295831 Opened 3 years ago Closed 3 years ago

Telemetry to support background video decoder suspend: Report single-keyframe videos

Categories

(Core :: Audio/Video: Playback, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Spawned from bug 1282012 comment 10, and follow-up to bug 1289668:
"""
Note that the inter-keyframe probe only gathers durations between successive decoded keyframes (see bug 1289668), meaning that if a video only has one keyframe it will not show up in the telemetry.
It may be possible to add a special case when we only see one keyframe, and record a '0' in this case, it would show up in the telemetry and could give us some sense of how prevalent they are.
"""

So the idea is that since there is no '0' values being recorded in the VIDEO_INTER_KEYFRAME_* telemetry (it doesn't really make sense), it should be possible to use this special value to record the number of long-enough (value TBD) videos that only have one keyframe -- making it difficult/impossible to seek back to some arbitrary position after a video-suspend.

This will require an incremental change in the probe description (controversial!?), and some logic to credibly infer that, as far as video-suspend feature is concerned, there is only one keyframe.
Comment on attachment 8782246 [details]
Bug 1295831 - Report VIDEO_INTER_KEYFRAME_MAX_MS=0 when only 1 keyframe -

https://reviewboard.mozilla.org/r/72436/#review70158
Attachment #8782246 - Flags: review?(kaku) → review+
Comment on attachment 8782245 [details]
Bug 1295831 - VIDEO_INTER_KEYFRAME_MAX_MS==0 means only 1 keyframe -

https://reviewboard.mozilla.org/r/72434/#review70444
Attachment #8782245 - Flags: review?(francois) → review+
Thank you Kaku and François for the reviews.
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5576171f4615
VIDEO_INTER_KEYFRAME_MAX_MS==0 means only 1 keyframe - r=francois
https://hg.mozilla.org/integration/autoland/rev/c592e44da5f3
Report VIDEO_INTER_KEYFRAME_MAX_MS=0 when only 1 keyframe - r=kaku
https://hg.mozilla.org/mozilla-central/rev/5576171f4615
https://hg.mozilla.org/mozilla-central/rev/c592e44da5f3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: 1297971
You need to log in before you can comment on or make changes to this bug.