Intermittent toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | test_stderr - [test_stderr : 467] Saw second line of stderr output on the console - -1 != -1

RESOLVED FIXED in Firefox 51

Status

defect
P3
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: intermittent-bug-filer, Assigned: kmag)

Tracking

({intermittent-failure})

unspecified
mozilla52
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox50 unaffected, firefox51 fixed, firefox52 fixed)

Details

Attachments

(1 attachment)

Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8783231 [details]
Bug 1295867: Wait for all IO operations to complete before ending test tasks.

https://reviewboard.mozilla.org/r/73136/#review70916

::: toolkit/modules/subprocess/subprocess_worker_common.js:150
(Diff revision 1)
>  
> -    return process.exitPromise.then(exitCode => {
> +    process.awaitFinished().then(() => {
>        io.cleanupProcess(process);
> +    });
> +
> +    return process.exitPromise.then(exitCode => {

I don't think it matters functionally but stylistically it looks strange to have this handler nested inside another handler instead of just returning exitPromise here and then chaining another top level handler.
Attachment #8783231 - Flags: review?(aswan) → review+
Assignee

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/64fc57e6ee841f55e2d2f196b51aff11b71a428e
Bug 1295867: Wait for all IO operations to complete before ending test tasks. r=aswan
Backed out for windows xpcshell failure test_native_messaging.js | test_native_app_shutdown:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd2a7ca95912162755bb744f6aac644a7dc3a27

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=64fc57e6ee841f55e2d2f196b51aff11b71a428e
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=34360757&repo=mozilla-inbound

14:53:50     INFO -  TEST-PASS | toolkit/components/extensions/test/xpcshell/test_native_messaging.js | test_native_app_shutdown - [test_native_app_shutdown : 265] Received test message - "test" == "test"
14:53:50     INFO -  "waiting for async shutdown"
14:53:50  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/xpcshell/test_native_messaging.js | test_native_app_shutdown - [test_native_app_shutdown : 283] native process exited - 1 == 0
14:53:50     INFO -      c:/slave/test/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_native_messaging.js:test_native_app_shutdown:283
14:53:50     INFO -      _run_next_test@c:\slave\test\build\tests\xpcshell\head.js:1564:9
14:53:50     INFO -      do_execute_soon/<.run@c:\slave\test\build\tests\xpcshell\head.js:712:9
14:53:50     INFO -      _do_main@c:\slave\test\build\tests\xpcshell\head.js:209:5
14:53:50     INFO -      _execute_test@c:\slave\test\build\tests\xpcshell\head.js:544:5
14:53:50     INFO -      @-e:1:1
14:53:50     INFO -  exiting test
14:53:50     INFO -  Unexpected exception 2147500036
Flags: needinfo?(kmaglione+bmo)
Assignee

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e42ea0dc67fd18a77ee9002d3f02f2d0dd5e2b
Bug 1295867: Wait for all IO operations to complete before ending test tasks. r=aswan
Comment hidden (Intermittent Failures Robot)

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8e42ea0dc67
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee

Updated

3 years ago
Flags: needinfo?(kmaglione+bmo)
Comment hidden (Intermittent Failures Robot)
Still happening.
Assignee: nobody → kmaglione+bmo
Status: RESOLVED → REOPENED
Flags: needinfo?(kmaglione+bmo)
Resolution: FIXED → ---
Target Milestone: mozilla51 → ---
Assignee

Comment 11

3 years ago
Well, it's not failing as often, at least. There's still a slight race. I think we just need to reorder some operations to fix it completely.
Flags: needinfo?(kmaglione+bmo)

Comment 12

3 years ago
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
25 failures in the last week, all Win8 debug :(
Flags: needinfo?(kmaglione+bmo)
Assignee

Comment 18

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/916c47f534c20427eecbb988453fe2e32004d4c4
Bug 1295867: Fix race in handling buffered stderr output from native app. r=me

Comment 19

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/916c47f534c2
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee

Updated

3 years ago
Flags: needinfo?(kmaglione+bmo)
Comment hidden (Intermittent Failures Robot)

Updated

11 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.