Closed Bug 1295867 Opened 8 years ago Closed 8 years ago

Intermittent toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | test_stderr - [test_stderr : 467] Saw second line of stderr output on the console - -1 != -1

Categories

(WebExtensions :: Untriaged, defect, P3)

Product:
WebExtensions
Component:
Untriaged
Type:
defect

Tracking

(firefox50 unaffected, firefox51 fixed, firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kmag)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1295867: Wait for all IO operations to complete before ending test tasks.
58 bytes, text/x-review-board-request
aswan
: review+
Details 
Comment on attachment 8783231 [details]
Bug 1295867: Wait for all IO operations to complete before ending test tasks.

https://reviewboard.mozilla.org/r/73136/#review70916

::: toolkit/modules/subprocess/subprocess_worker_common.js:150
(Diff revision 1)
>  
> -    return process.exitPromise.then(exitCode => {
> +    process.awaitFinished().then(() => {
>        io.cleanupProcess(process);
> +    });
> +
> +    return process.exitPromise.then(exitCode => {

I don't think it matters functionally but stylistically it looks strange to have this handler nested inside another handler instead of just returning exitPromise here and then chaining another top level handler.
Attachment #8783231 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/64fc57e6ee841f55e2d2f196b51aff11b71a428e
Bug 1295867: Wait for all IO operations to complete before ending test tasks. r=aswan
Backed out for windows xpcshell failure test_native_messaging.js | test_native_app_shutdown:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd2a7ca95912162755bb744f6aac644a7dc3a27

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=64fc57e6ee841f55e2d2f196b51aff11b71a428e
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=34360757&repo=mozilla-inbound

14:53:50     INFO -  TEST-PASS | toolkit/components/extensions/test/xpcshell/test_native_messaging.js | test_native_app_shutdown - [test_native_app_shutdown : 265] Received test message - "test" == "test"
14:53:50     INFO -  "waiting for async shutdown"
14:53:50  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/xpcshell/test_native_messaging.js | test_native_app_shutdown - [test_native_app_shutdown : 283] native process exited - 1 == 0
14:53:50     INFO -      c:/slave/test/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_native_messaging.js:test_native_app_shutdown:283
14:53:50     INFO -      _run_next_test@c:\slave\test\build\tests\xpcshell\head.js:1564:9
14:53:50     INFO -      do_execute_soon/<.run@c:\slave\test\build\tests\xpcshell\head.js:712:9
14:53:50     INFO -      _do_main@c:\slave\test\build\tests\xpcshell\head.js:209:5
14:53:50     INFO -      _execute_test@c:\slave\test\build\tests\xpcshell\head.js:544:5
14:53:50     INFO -      @-e:1:1
14:53:50     INFO -  exiting test
14:53:50     INFO -  Unexpected exception 2147500036
Flags: needinfo?(kmaglione+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e42ea0dc67fd18a77ee9002d3f02f2d0dd5e2b
Bug 1295867: Wait for all IO operations to complete before ending test tasks. r=aswan
https://hg.mozilla.org/mozilla-central/rev/a8e42ea0dc67
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Flags: needinfo?(kmaglione+bmo)
Still happening.
Assignee: nobody → kmaglione+bmo
Status: RESOLVED → REOPENED
status-firefox51: fixed → affected
Flags: needinfo?(kmaglione+bmo)
Resolution: FIXED → ---
Target Milestone: mozilla51 → ---
Well, it's not failing as often, at least. There's still a slight race. I think we just need to reorder some operations to fix it completely.
Flags: needinfo?(kmaglione+bmo)
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
25 failures in the last week, all Win8 debug :(
status-firefox50: --- → unaffected
status-firefox52: --- → affected
Flags: needinfo?(kmaglione+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/916c47f534c20427eecbb988453fe2e32004d4c4
Bug 1295867: Fix race in handling buffered stderr output from native app. r=me
https://hg.mozilla.org/mozilla-central/rev/916c47f534c2
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Flags: needinfo?(kmaglione+bmo)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: