1295867 - Intermittent toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | test_stderr - [test_stderr : 467] Saw second line of stderr output on the console - -1 != -1

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=33969723&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64-debug/1471381035/mozilla-inbound_win8_64-debug_test-xpcshell-bm110-tests1-windows-build3045.txt.gz

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1295867: Wait for all IO operations to complete before ending test tasks.

Review commit: https://reviewboard.mozilla.org/r/73136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73136/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8783231 [details]
Bug 1295867: Wait for all IO operations to complete before ending test tasks.

https://reviewboard.mozilla.org/r/73136/#review70916

::: toolkit/modules/subprocess/subprocess_worker_common.js:150
(Diff revision 1)
>  
> -    return process.exitPromise.then(exitCode => {
> +    process.awaitFinished().then(() => {
>        io.cleanupProcess(process);
> +    });
> +
> +    return process.exitPromise.then(exitCode => {

I don't think it matters functionally but stylistically it looks strange to have this handler nested inside another handler instead of just returning exitPromise here and then chaining another top level handler.

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64fc57e6ee841f55e2d2f196b51aff11b71a428e
Bug 1295867: Wait for all IO operations to complete before ending test tasks. r=aswan

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for windows xpcshell failure test_native_messaging.js | test_native_app_shutdown:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd2a7ca95912162755bb744f6aac644a7dc3a27

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=64fc57e6ee841f55e2d2f196b51aff11b71a428e
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=34360757&repo=mozilla-inbound

14:53:50     INFO -  TEST-PASS | toolkit/components/extensions/test/xpcshell/test_native_messaging.js | test_native_app_shutdown - [test_native_app_shutdown : 265] Received test message - "test" == "test"
14:53:50     INFO -  "waiting for async shutdown"
14:53:50  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/xpcshell/test_native_messaging.js | test_native_app_shutdown - [test_native_app_shutdown : 283] native process exited - 1 == 0
14:53:50     INFO -      c:/slave/test/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_native_messaging.js:test_native_app_shutdown:283
14:53:50     INFO -      _run_next_test@c:\slave\test\build\tests\xpcshell\head.js:1564:9
14:53:50     INFO -      do_execute_soon/<.run@c:\slave\test\build\tests\xpcshell\head.js:712:9
14:53:50     INFO -      _do_main@c:\slave\test\build\tests\xpcshell\head.js:209:5
14:53:50     INFO -      _execute_test@c:\slave\test\build\tests\xpcshell\head.js:544:5
14:53:50     INFO -      @-e:1:1
14:53:50     INFO -  exiting test
14:53:50     INFO -  Unexpected exception 2147500036

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e42ea0dc67fd18a77ee9002d3f02f2d0dd5e2b
Bug 1295867: Wait for all IO operations to complete before ending test tasks. r=aswan

Comment 7

[Intermittent Failures Robot]

34 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 24
* mozilla-central: 4
* fx-team: 4
* autoland: 2

Platform breakdown:
* windows8-64: 33
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295867&startday=2016-08-15&endday=2016-08-21&tree=all

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a8e42ea0dc67

Comment 9

[Intermittent Failures Robot]

17 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 11
* mozilla-inbound: 5
* fx-team: 1

Platform breakdown:
* windows8-64: 15
* windowsxp: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295867&startday=2016-08-22&endday=2016-08-28&tree=all

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Still happening.

Comment 11

[Kris Maglione [:kmag]]

Well, it's not failing as often, at least. There's still a slight race. I think we just need to reorder some operations to fix it completely.

Comment 12

[BMO Automation]

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.

Comment 13

[Intermittent Failures Robot]

14 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6
* autoland: 6
* mozilla-central: 1
* fx-team: 1

Platform breakdown:
* windows8-64: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295867&startday=2016-08-29&endday=2016-09-04&tree=all

Comment 14

[Intermittent Failures Robot]

9 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 4
* mozilla-inbound: 3
* fx-team: 2

Platform breakdown:
* windows8-64: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295867&startday=2016-09-05&endday=2016-09-11&tree=all

Comment 15

[Intermittent Failures Robot]

17 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 7
* mozilla-inbound: 4
* fx-team: 3
* autoland: 2
* try: 1

Platform breakdown:
* windows8-64: 16
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295867&startday=2016-09-12&endday=2016-09-18&tree=all

Comment 16

[Intermittent Failures Robot]

31 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 12
* autoland: 11
* fx-team: 5
* mozilla-aurora: 2
* mozilla-central: 1

Platform breakdown:
* windows8-64: 31

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295867&startday=2016-09-19&endday=2016-09-25&tree=all

Comment 17

[Ryan VanderMeulen [:RyanVM]]

25 failures in the last week, all Win8 debug :(

Comment 18

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/916c47f534c20427eecbb988453fe2e32004d4c4
Bug 1295867: Fix race in handling buffered stderr output from native app. r=me

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/916c47f534c2

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d82174b4dfa7

Comment 21

[Intermittent Failures Robot]

27 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 11
* autoland: 9
* mozilla-aurora: 4
* fx-team: 2
* mozilla-central: 1

Platform breakdown:
* windows8-64: 27

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1295867&startday=2016-09-26&endday=2016-10-02&tree=all