Closed Bug 1295885 Opened 3 years ago Closed 3 years ago

Remove netwerk/protocol/rtsp

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-would-take])

Attachments

(1 file)

No description provided.
Hey Mike,

I suppose to do what you're doing here in bug 1291080.
Besides removing the directory netwerk/protocol/rtsp, we need to clean up some leftover RTSP codes as well.

Do you mind if I do the code removal in that bug?
Flags: needinfo?(mh+mozilla)
Bug 1295516 effectively removed everything that would make the rtsp network code compile. Removing it can be done separately from any other cleanup. OTOH, I do need the directory removed to simplify the task of finishing bug 1276003, so I'd rather go forward here.
Flags: needinfo?(mh+mozilla)
(In reply to Mike Hommey [:glandium] from comment #3)
> Bug 1295516 effectively removed everything that would make the rtsp network
> code compile. Removing it can be done separately from any other cleanup.
> OTOH, I do need the directory removed to simplify the task of finishing bug
> 1276003, so I'd rather go forward here.

Sure. Then I'll just clean up any leftovers in bug 1291080.
Thanks.
Comment on attachment 8781855 [details]
Bug 1295885 - Remove netwerk/protocol/rtsp.

https://reviewboard.mozilla.org/r/72190/#review69858
Attachment #8781855 - Flags: review?(mcmanus) → review+
Whiteboard: [necko-would-take]
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/cad914b2d68b
Remove netwerk/protocol/rtsp. r=mcmanus
https://hg.mozilla.org/mozilla-central/rev/cad914b2d68b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
mach complained about inexistence of netwerk/protocols/rtsp/moz.build when I build, even with a clobber. Eventually it turns out that the list of NECKO_PROTOCOLS is generated based on subdirectories of netwerk/protocols, and I still have that rtsp directory there because of a leftover .orig file.

(Probably the build script should check netwerk/protocols/*/moz.build instead of listing the subdirectories.)

If anyone meets the same issue (probably no one, it seems), you could manually remove netwerk/protocols/rtsp and try to build again.
Please file a followup bug.
You need to log in before you can comment on or make changes to this bug.