1295885 - Remove netwerk/protocol/rtsp

Status: RESOLVED FIXED

(Core :: Networking, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1295885 - Remove netwerk/protocol/rtsp.

The only user of the RTSP protocol was removed in bug 1291629 and bug 1295516.

Review commit: https://reviewboard.mozilla.org/r/72190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72190/

Comment 2

[Ethan Tseng [:ethan]]

Hey Mike,

I suppose to do what you're doing here in bug 1291080.
Besides removing the directory netwerk/protocol/rtsp, we need to clean up some leftover RTSP codes as well.

Do you mind if I do the code removal in that bug?

Comment 3

[Mike Hommey [:glandium]]

Bug 1295516 effectively removed everything that would make the rtsp network code compile. Removing it can be done separately from any other cleanup. OTOH, I do need the directory removed to simplify the task of finishing bug 1276003, so I'd rather go forward here.

Comment 4

[Ethan Tseng [:ethan]]

(In reply to Mike Hommey [:glandium] from comment #3)
> Bug 1295516 effectively removed everything that would make the rtsp network
> code compile. Removing it can be done separately from any other cleanup.
> OTOH, I do need the directory removed to simplify the task of finishing bug
> 1276003, so I'd rather go forward here.

Sure. Then I'll just clean up any leftovers in bug 1291080.
Thanks.

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 8781855 [details]
Bug 1295885 - Remove netwerk/protocol/rtsp.

https://reviewboard.mozilla.org/r/72190/#review69858

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cad914b2d68b
Remove netwerk/protocol/rtsp. r=mcmanus

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cad914b2d68b

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

mach complained about inexistence of netwerk/protocols/rtsp/moz.build when I build, even with a clobber. Eventually it turns out that the list of NECKO_PROTOCOLS is generated based on subdirectories of netwerk/protocols, and I still have that rtsp directory there because of a leftover .orig file.

(Probably the build script should check netwerk/protocols/*/moz.build instead of listing the subdirectories.)

If anyone meets the same issue (probably no one, it seems), you could manually remove netwerk/protocols/rtsp and try to build again.

Comment 9

[Mike Hommey [:glandium]]

Please file a followup bug.