|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Use enum class instead of enum for memory saving.
How does enum class save more memory than enum?
(In reply to JW Wang [:jwwang] from comment #2) > How does enum class save more memory than enum? More specifically, using enum class : uint8_t instead of enum (integer) to save memory. Another reason is using strong type |enum class| is more encouraged.
The memory saving (which is quite insignificant unless they are stored in an array) doesn't justify this bug as much as strong typing.
Comment on attachment 8781933 [details] Bug 1295920 - Replace enum with enum class in PlatformDecoderModule.h. https://reviewboard.mozilla.org/r/72248/#review70090 Assuming it all compiles on all platform of course...
Attachment #8781933 - Flags: review?(jyavenard) → review+
Thanks for reviewing. It can be compiled in all platforms. https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2037ad7fcb1
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/82cacf7d008a Replace enum with enum class in PlatformDecoderModule.h. r=jya
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.