1296079 - Disable dump() calls in dom/browser-element

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Various browser element frame scripts have always on dump() calls to say they are loaded.  I am not sure there is much value in keeping these.

I'd say let's remove them, or at least comment them out.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1296079 - Remove dump() calls in dom/browser-element.

Review commit: https://reviewboard.mozilla.org/r/72370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72370/

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8782131 [details]
Bug 1296079 - Remove dump() calls in dom/browser-element.

https://reviewboard.mozilla.org/r/72370/#review70976

They were very useful to debug when the frame script is loaded or if they were loaded multiple times unnecessary.
Keep it and replace dump with debug then r+

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8782131 [details]
Bug 1296079 - Remove dump() calls in dom/browser-element.

https://reviewboard.mozilla.org/r/72370/#review70976

Makes sense, I'll add debug functions with their dump calls commented out so it's disabled by default.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea40550e91ed
Disable dump() calls in dom/browser-element. r=kanru

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea40550e91ed