Closed Bug 1296079 Opened 5 years ago Closed 5 years ago

Disable dump() calls in dom/browser-element

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file)

Various browser element frame scripts have always on dump() calls to say they are loaded.  I am not sure there is much value in keeping these.

I'd say let's remove them, or at least comment them out.
Comment on attachment 8782131 [details]
Bug 1296079 - Remove dump() calls in dom/browser-element.

https://reviewboard.mozilla.org/r/72370/#review70976

They were very useful to debug when the frame script is loaded or if they were loaded multiple times unnecessary.
Keep it and replace dump with debug then r+
Attachment #8782131 - Flags: review?(kchen) → review+
Comment on attachment 8782131 [details]
Bug 1296079 - Remove dump() calls in dom/browser-element.

https://reviewboard.mozilla.org/r/72370/#review70976

Makes sense, I'll add debug functions with their dump calls commented out so it's disabled by default.
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea40550e91ed
Disable dump() calls in dom/browser-element. r=kanru
Summary: Remove always on dump() calls in dom/browser-element → Disable dump() calls in dom/browser-element
https://hg.mozilla.org/mozilla-central/rev/ea40550e91ed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.