Closed Bug 1296097 Opened 4 years ago Closed 4 years ago

Use new XMLHttpRequest() instead of nsIXMLHttpRequest

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

Bug 1295896 removed the use of the mock nsIXMLHttpRequest and bug 792808 which will remove the in tree js consumers of nsIXMLHttpRequest. This bug is to change app update to use new XMLHttpRequest().
Attached patch patch rev1Splinter Review
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Comment on attachment 8782163 [details] [diff] [review]
patch rev1

Pushed to try along with other app update patches that haven't yet merged to m-c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aeb23f1aaf57
Comment on attachment 8782163 [details] [diff] [review]
patch rev1

Since the taskcluster failed to schedule the try jobs I pushed to try again
https://treeherder.mozilla.org/#/jobs?repo=try&revision=30c763f49c38

Thomas, does this patch accomplish what you want for bug 792808? Note that the remaining app update tests that use nsIXMLHttpRequest will be removed by bug 1182352 which this bug depends on.
Attachment #8782163 - Flags: feedback?(wisniewskit)
Comment on attachment 8782163 [details] [diff] [review]
patch rev1

Yes, it looks like this should do it. Thanks!

I'll rebase/obsolete my patches and resume my work in bug 792808 once bug 1182352 is done.
Attachment #8782163 - Flags: feedback?(wisniewskit) → feedback+
Comment on attachment 8782163 [details] [diff] [review]
patch rev1

Hi Matt, I'll be sure to land the patches in bug 1182352 prior to landing this.
Attachment #8782163 - Flags: review?(mhowell)
Comment on attachment 8782163 [details] [diff] [review]
patch rev1

Review of attachment 8782163 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good! Thanks.
Attachment #8782163 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbbadfa14ef1
Use new XMLHttpRequest() instead of nsIXMLHttpRequest.
https://hg.mozilla.org/mozilla-central/rev/bbbadfa14ef1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.