Closed
Bug 1296097
Opened 8 years ago
Closed 8 years ago
Use new XMLHttpRequest() instead of nsIXMLHttpRequest
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file)
|
4.32 KB,
patch
|
molly
:
review+
wisniewskit
:
feedback+
|
Details | Diff | Splinter Review |
Bug 1295896 removed the use of the mock nsIXMLHttpRequest and bug 792808 which will remove the in tree js consumers of nsIXMLHttpRequest. This bug is to change app update to use new XMLHttpRequest().
|
Assignee | |
Comment 1•8 years ago
|
||
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8782163 [details] [diff] [review] patch rev1 Pushed to try along with other app update patches that haven't yet merged to m-c https://treeherder.mozilla.org/#/jobs?repo=try&revision=aeb23f1aaf57
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8782163 [details] [diff] [review] patch rev1 Since the taskcluster failed to schedule the try jobs I pushed to try again https://treeherder.mozilla.org/#/jobs?repo=try&revision=30c763f49c38 Thomas, does this patch accomplish what you want for bug 792808? Note that the remaining app update tests that use nsIXMLHttpRequest will be removed by bug 1182352 which this bug depends on.
Attachment #8782163 -
Flags: feedback?(wisniewskit)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8782163 [details] [diff] [review] patch rev1 Yes, it looks like this should do it. Thanks! I'll rebase/obsolete my patches and resume my work in bug 792808 once bug 1182352 is done.
Attachment #8782163 -
Flags: feedback?(wisniewskit) → feedback+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8782163 [details] [diff] [review] patch rev1 Hi Matt, I'll be sure to land the patches in bug 1182352 prior to landing this.
Attachment #8782163 -
Flags: review?(mhowell)
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8782163 [details] [diff] [review] patch rev1 Review of attachment 8782163 [details] [diff] [review]: ----------------------------------------------------------------- Sounds good! Thanks.
Attachment #8782163 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bbbadfa14ef1 Use new XMLHttpRequest() instead of nsIXMLHttpRequest.
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bbbadfa14ef1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•