Closed
Bug 1296112
Opened 9 years ago
Closed 9 years ago
Top tabs has several issues with private mode authentication
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1256470
People
(Reporter: nalcock, Assigned: nalcock)
Details
Attachments
(1 file)
1. Switching between private mode via the top tabs mask button causes visual issues.
2. Opening a new tab with the plus button causes a crash.
3. Closing the last private tab causes a crash.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nalcock
|
|
Assignee | |
Comment 1•9 years ago
|
||
The method of switching using Deferred just broke down completely for top tabs, as there were so many race conditions, leading to buggy animations and crashes. This now uses completion handlers, and it's so much easier to work with (I think the code is also probably easier to follow.) This should fix up all the existing issues, which means the top tabs UI improvement work can land after this one.
Attachment #8782526 -
Flags: review?(sleroux)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8782526 [details] [review]
Pull request
Left comments on the PR!
Attachment #8782526 -
Flags: feedback+
|
|
Assignee | |
Comment 3•9 years ago
|
||
The work on fixing the bugs with these features is being moved back to: https://bugzilla.mozilla.org/show_bug.cgi?id=1256470
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
|
|
||
Updated•9 years ago
|
Attachment #8782526 -
Flags: review?(sleroux)
You need to log in
before you can comment on or make changes to this bug.
Description
•