1296157 - pulse_actions - Triggering tests for a failed build doesn't realize it needs to retrigger the build

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Phil Ringnalda (:philor)]

In https://treeherder.mozilla.org/#/jobs?repo=try&revision=86bd58c71521&group_state=expanded after being unsuccessful at getting a Windows 8 x64 opt build to succeed a second time (thanks to a pair of infra bustages and bad timing), kats decided to see whether using Add new Jobs in Treeherder to add the tests would make him luckier.

It didn't, because pulse_actions has the mistaken idea that a build failure results in "mozci We have the necessary files to trigger the downstream job." as https://tc-gp-public-31d.s3-us-west-2.amazonaws.com/ateam/pulse-action-dev/fb549273-b991-44a5-82c8-4eb3a07e0dfe puts it. What it actually results in is https://treeherder.mozilla.org/logviewer.html#?job_id=25876933&repo=try and triggering a broken test job because there aren't any files in the buildbot props (because there aren't any files that could be in there, because the build failed so there's no binary and no test zips).

Comment 1

[Armen [:armenzg]]

Thanks philor for filing this.
I will review this in detail after I go through my post PTO backlog of bugmail and determine how to fix this.

Comment 2

[Armen [:armenzg]]

I started looking at this last week but it was not easy to determine what happened.
mozci has ways to prevent scheduling jobs with invalid (404) test and installer urls.

Comment 3

[Armen [:armenzg]]

So, there was a bug in the logic to detect if files are found for a build.

I've fixed this in https://github.com/mozilla/mozilla_ci_tools/commit/02f6404a59d4a7394228e00e2cd8f99db7d60fc8#diff-fceb32314e6c82e12ca12ab409d93d8aL209

I will hopefully deploying this on Tuesday.

Comment 4

[Armen [:armenzg]]

I deployed the code.
Thank you very much for reporting it!

Comment 5

[Armen [:armenzg]]

I was not able to verify that this is fixed because of bug 1300795, however, from inpection of the logs, it is working for backfill requests (I think).