Closed
Bug 1296168
Opened 8 years ago
Closed 8 years ago
Can't submit beta or esr release - "Version must match either X.0 or X.Y.Z"
Categories
(Release Engineering :: Applications: Shipit, defect)
Release Engineering
Applications: Shipit
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wsmwk, Assigned: jlorenzo)
References
Details
(Keywords: regression)
Attachments
(2 files)
I fill in the blanks in ship-it and click Gimme a Thunderbird, I see "Version must match either X.0 or X.Y.Z". The version I supplied is 49.0b1 (see scree shot). I can't get a build. nthomas points out on IRC this is related to bug 1293654 and my bug 1283481, and says "I get the problem for both TB and FF betas, in docker"
Comment 1•8 years ago
|
||
Broadening to include Firefox, beta and ESR. Looks like https://github.com/mozilla-releng/ship-it/blob/ca3db03e6d82d9f392ee61b655356625a432838e/kickoff/views/forms.py#L200 is too narrow for those cases.
Severity: normal → critical
Summary: ship-it Gimme a Thunderbird consistently warns "Version must match either X.0 or X.Y.Z" → Can't submit beta or esr release - "Version must match either X.0 or X.Y.Z"
Comment 2•8 years ago
|
||
FYI RelMan.
Comment 3•8 years ago
|
||
This passes all the tests, but we probably need some new ones: VALID_VERSION_PATTERN = re.compile(r'^(\d+\.0|\d+\.\d+\.\d+)(b\d+|esr)?$')
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8782303 -
Flags: review?(rail)
Assignee | ||
Comment 5•8 years ago
|
||
Sorry for the breakage guys. I added tests to explicitly check valid versions (beta and ESR included).
Updated•8 years ago
|
Attachment #8782303 -
Flags: review?(rail) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Landed at https://github.com/mozilla-releng/ship-it/commit/f0288cc69e58968bdda13c84a8698f2b0cda048f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 7•8 years ago
|
||
Thanks for the quick fix Johan.
Updated•2 years ago
|
Component: Applications: ShipIt (backend) → Applications: ShipIt
You need to log in
before you can comment on or make changes to this bug.
Description
•