1296168 - Can't submit beta or esr release - "Version must match either X.0 or X.Y.Z"

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[Wayne Mery (:wsmwk)]

Attachment: ship-it version must match error.png

I fill in the blanks in ship-it and click Gimme a Thunderbird, I see "Version must match either X.0 or X.Y.Z". The version I supplied is 49.0b1 (see scree shot). I can't get a build.

nthomas points out on IRC this is related to bug 1293654 and my bug 1283481, and says "I get the problem for both TB and FF betas, in docker"

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Broadening to include Firefox, beta and ESR. Looks like
 https://github.com/mozilla-releng/ship-it/blob/ca3db03e6d82d9f392ee61b655356625a432838e/kickoff/views/forms.py#L200
is too narrow for those cases.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

FYI RelMan.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

This passes all the tests, but we probably need some new ones:

VALID_VERSION_PATTERN = re.compile(r'^(\d+\.0|\d+\.\d+\.\d+)(b\d+|esr)?$')

Comment 4

[Johan Lorenzo [:jlorenzo]]

Attachment: PR

Comment 5

[Johan Lorenzo [:jlorenzo]]

Sorry for the breakage guys. I added tests to explicitly check valid versions (beta and ESR included).

Comment 6

[Johan Lorenzo [:jlorenzo]]

Landed at https://github.com/mozilla-releng/ship-it/commit/f0288cc69e58968bdda13c84a8698f2b0cda048f

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Thanks for the quick fix Johan.