1296220 - Rename nsIMEUpdatePreference to something in mozilla::widget

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsIMEUpdatePreference is the last class which is in global namespace and has "ns" prefix. So, I'd like to move this into mozilla::widget and rename it to better name.

However, I'm not sure what's the best name of it. It has types of notifications which the widget needs to receive for handling native IME.
https://dxr.mozilla.org/mozilla-central/rev/fe895421dfbe1f1f8f1fc6a39bb20774423a6d74/widget/IMEData.h#35

So, RequiredIMENotifications or RequestedIMENotifications is a good name?

Any ideas?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> nsIMEUpdatePreference is the last class which is in global namespace and has "ns" prefix.

I meant it's the last IME related class in XP level.

Comment 2

[Jim Mathies [:jimm]]

How about IMENotificationRequests ?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Jim Mathies [:jimm] from comment #2)
> How about IMENotificationRequests ?

Sounds good, thanks!

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a65635897035b2646c56ec950160d7ea1bc1ae2c

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1296220 Rename nsIMEUpdatePreference to mozilla::widget::IMEUpdatePreference

Review commit: https://reviewboard.mozilla.org/r/128874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128874/

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 8857022 [details]
Bug 1296220 Rename nsIMEUpdatePreference to mozilla::widget::IMEUpdatePreference

https://reviewboard.mozilla.org/r/128874/#review131776

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d081bf9b839
Rename nsIMEUpdatePreference to mozilla::widget::IMEUpdatePreference r=m_kato

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8d081bf9b839