Closed Bug 1296220 Opened 4 years ago Closed 4 years ago

Rename nsIMEUpdatePreference to something in mozilla::widget

Categories

(Core :: Widget, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox51 --- affected
firefox55 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: inputmethod, Whiteboard: tpi:-)

Attachments

(1 file)

nsIMEUpdatePreference is the last class which is in global namespace and has "ns" prefix. So, I'd like to move this into mozilla::widget and rename it to better name.

However, I'm not sure what's the best name of it. It has types of notifications which the widget needs to receive for handling native IME.
https://dxr.mozilla.org/mozilla-central/rev/fe895421dfbe1f1f8f1fc6a39bb20774423a6d74/widget/IMEData.h#35

So, RequiredIMENotifications or RequestedIMENotifications is a good name?

Any ideas?
> nsIMEUpdatePreference is the last class which is in global namespace and has "ns" prefix.

I meant it's the last IME related class in XP level.
How about IMENotificationRequests ?
Whiteboard: tpi:-
(In reply to Jim Mathies [:jimm] from comment #2)
> How about IMENotificationRequests ?

Sounds good, thanks!
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Comment on attachment 8857022 [details]
Bug 1296220 Rename nsIMEUpdatePreference to mozilla::widget::IMEUpdatePreference

https://reviewboard.mozilla.org/r/128874/#review131776
Attachment #8857022 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/8d081bf9b839
Rename nsIMEUpdatePreference to mozilla::widget::IMEUpdatePreference r=m_kato
https://hg.mozilla.org/mozilla-central/rev/8d081bf9b839
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.