Closed
Bug 1296265
Opened 8 years ago
Closed 8 years ago
nsRuleNode.cpp: Value stored to 'scriptLevelAdjustedParentSize' during its initialization is never read
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: clang-analyzer)
Attachments
(1 file)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
QA Contact: sledru
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8782423 [details] Bug 1296265 - Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". https://reviewboard.mozilla.org/r/72602/#review70880 Thanks for catching & fixing this! r=me, with one request -- before landing, please change the commit message so that it describes the change, rather than simply quoting the warning being addressed. (This is a general rule for Gecko commit messages -- see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment for more on this.) Suggested replacement commit message: Bug 1296265 - Collapse assignments to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize", since the first one is never used. r=dholbert
Attachment #8782423 -
Flags: review?(dholbert) → review+
Comment 3•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8782423 [details] Bug 1296265 - Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". https://reviewboard.mozilla.org/r/72602/#review70880 Gahhh, sorry for the """ junk in my suggested commit message above. Those were originally quote characters, but MozReview bungled them up due to a version of bug 1283024.
Comment 4•8 years ago
|
||
Alternate (shorter, possibly clearer) commit message: Bug 1296265 - Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". r=dholbert
Note that this made sense when the MOZ_MATHML #ifdefs were present, but probably should have been removed along with them.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9de2153ec067 Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". r=dholbert
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sledru
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9de2153ec067
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Updated•5 years ago
|
QA Contact: sledru
You need to log in
before you can comment on or make changes to this bug.
Description
•