Closed
Bug 1296273
Opened 8 years ago
Closed 8 years ago
Remove subarray and copyWithin from vm/TypedArrayCommon.h
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
7.95 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
The subarray and copyWithin methods in vm/TypedArrayCommon.h don't appear to be used anymore (cf. bug 1176214), so we should probably remove them. [1] http://hg.mozilla.org/mozilla-central/file/97a52326b06a/js/src/vm/TypedArrayCommon.h#l611 [2] http://hg.mozilla.org/mozilla-central/file/97a52326b06a/js/src/vm/TypedArrayCommon.h#l703
|
Assignee | |
Comment 1•8 years ago
|
||
The C++ implementations of subarray() and copyWithin() are no longer used.
|
|
Assignee | |
Comment 2•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=86cf94147997f0676e8a12b2416eadd8dcc32676
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8802262 [details] [diff] [review] bug1296273.patch Review of attachment 8802262 [details] [diff] [review]: ----------------------------------------------------------------- The smaller TypedArrayCommon.h becomes, the better, in my opinion...
Attachment #8802262 -
Flags: review?(lhansen) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ddce297cab Remove no longer used native implementation of TypedArray methods. r=lth
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c9ddce297cab
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•