Remove subarray and copyWithin from vm/TypedArrayCommon.h

RESOLVED FIXED in Firefox 52

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox51 affected, firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The subarray and copyWithin methods in vm/TypedArrayCommon.h don't appear to be used anymore (cf. bug 1176214), so we should probably remove them.

[1] http://hg.mozilla.org/mozilla-central/file/97a52326b06a/js/src/vm/TypedArrayCommon.h#l611
[2] http://hg.mozilla.org/mozilla-central/file/97a52326b06a/js/src/vm/TypedArrayCommon.h#l703
(Assignee)

Comment 1

2 years ago
Created attachment 8802262 [details] [diff] [review]
bug1296273.patch

The C++ implementations of subarray() and copyWithin() are no longer used.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8802262 - Flags: review?(lhansen)
Comment on attachment 8802262 [details] [diff] [review]
bug1296273.patch

Review of attachment 8802262 [details] [diff] [review]:
-----------------------------------------------------------------

The smaller TypedArrayCommon.h becomes, the better, in my opinion...
Attachment #8802262 - Flags: review?(lhansen) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ddce297cab
Remove no longer used native implementation of TypedArray methods. r=lth
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9ddce297cab
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.