Closed Bug 1296273 Opened 7 years ago Closed 7 years ago

Remove subarray and copyWithin from vm/TypedArrayCommon.h

Categories

(Core :: JavaScript: Standard Library, defect)

Product:
Core
Component:
JavaScript: Standard Library
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- affected
firefox52 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

bug1296273.patch
7.95 KB, patch
lth
: review+
Details | Diff | Splinter Review 
The subarray and copyWithin methods in vm/TypedArrayCommon.h don't appear to be used anymore (cf. bug 1176214), so we should probably remove them.

[1] http://hg.mozilla.org/mozilla-central/file/97a52326b06a/js/src/vm/TypedArrayCommon.h#l611
[2] http://hg.mozilla.org/mozilla-central/file/97a52326b06a/js/src/vm/TypedArrayCommon.h#l703
Attached patch bug1296273.patch — — Splinter Review 
The C++ implementations of subarray() and copyWithin() are no longer used.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8802262 - Flags: review?(lhansen)
Comment on attachment 8802262 [details] [diff] [review]
bug1296273.patch

Review of attachment 8802262 [details] [diff] [review]:
-----------------------------------------------------------------

The smaller TypedArrayCommon.h becomes, the better, in my opinion...
Attachment #8802262 - Flags: review?(lhansen) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ddce297cab
Remove no longer used native implementation of TypedArray methods. r=lth
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c9ddce297cab
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.