Add alert_emails & bug_numbers for new HTTP_RESPONSE_STATUS_CODE probe

RESOLVED FIXED in Firefox 51

Status

()

Core
Networking
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gfritzsche, Assigned: ckerschb)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [necko-backlog])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Bug 1272345 added a new HTTP_RESPONSE_STATUS_CODE probes to Histograms.json but didn't add "alert_emails" and "bug_numbers".
These are required now, histogram-whitelists.json is only used for old probes that don't have those fields yet.

Please add "alert_emails" & "bug_numbers" for these probes and remove them from histogram-whitelists.son.

Also note that new probes in general require data collection review:
https://wiki.mozilla.org/Firefox/Data_Collection
Flags: needinfo?(ckerschb)
Whiteboard: [necko-backlog]
(Assignee)

Comment 1

a year ago
Created attachment 8782805 [details] [diff] [review]
bug_1296287_http_response_status_probe_update.patch

Thanks Georg for bringing this to my attention.
Flags: needinfo?(ckerschb)
Attachment #8782805 - Flags: review?(gfritzsche)
(Assignee)

Updated

a year ago
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
(Reporter)

Comment 2

a year ago
Comment on attachment 8782805 [details] [diff] [review]
bug_1296287_http_response_status_probe_update.patch

Review of attachment 8782805 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: toolkit/components/telemetry/Histograms.json
@@ +1393,5 @@
>      "description": "Was the URL upgraded to HTTPS?  (0=already HTTPS, 1=no reason to upgrade, 2=STS upgrade blocked by pref, 3=upgraded with STS, 4=upgraded with CSP)"
>    },
>    "HTTP_RESPONSE_STATUS_CODE": {
> +    "alert_emails": ["ckerschbaumer@mozilla.com"],
> +    "bug_numbers": [1272345,1296287],

Readability nit: missing space between the bug numbers.
Attachment #8782805 - Flags: review?(gfritzsche) → review+

Comment 3

a year ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f4851295cc
Add alert_emails & bug_numbers for new HTTP_RESPONSE_STATUS_CODE probe. r=gfritzsche

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b2f4851295cc
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.