1296333 - Minor mscom fixes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Some stuff found while debugging:

1) The interceptor needs to be able to handle IUnknown;
2) We need to properly handle encountering a nullptr when wrapping outparam interfaces;
3) Our assertion in the COMPtrHolder serializer should be willing to accept nullptr as a possible input.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6174c5855f49d9ea91c588165f4728363ff5866
Bug 1296333: Ensure better handling of nullptr and IUnknown in ipc::mscom; r=jimm

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b6174c5855f4