Closed Bug 1296383 Opened 9 years ago Closed 9 years ago

Upgrade angular to version 1.5.8

Categories

(Tree Management :: Treeherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(1 file)

Angular 1.5 has better support for ES6 arrow functions (http://stackoverflow.com/a/32700361) and a new component (replaces directives) which is easier to use: https://toddmotto.com/exploring-the-angular-1-5-component-method/ As I'm going to be writing a bunch of new code for Infraherder, this seems like a good time to upgrade. It seems to be pretty much backwards compatible in preliminary testing, I'll run the moztrap tests to be safe.
Comment on attachment 8782622 [details] [review] [treeherder] mozilla:stage > mozilla:master I did a full moztrap test. There was a minor bug in the way we were doing resultset sorting that needed to be fixed, but otherwise things look good (or are at least as good as before, I noticed some issues in the autoclassify panel with non-structured failures).
Attachment #8782622 - Flags: review?(cdawson)
Blocks: 1296692
Comment on attachment 8782622 [details] [review] [treeherder] mozilla:stage > mozilla:master Thanks for doing this! :)
Attachment #8782622 - Flags: review?(cdawson) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: