1296432 - stylo: Avoid probing pseudo-elements unconditionally for every element

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[Emilio Cobos Álvarez (:emilio)]

In bug 1292618 incremental restyle for :before and :after is implemented probing each possible pseudo-element for each element we restyle. Seems reasonable to add a element bit to signal we have pseudo-elements to restyle to avoid doing all that work in the common case that there are none.

Comment 1

[Cameron McCormack (:heycam)]

How and when would we accurately set this bit if we don't perform the selector matching to determine whether there is a ::before / ::after rule that matches the element?

Comment 2

[Bobby Holley (:bholley)]

(In reply to Cameron McCormack (:heycam) from comment #1)
> How and when would we accurately set this bit if we don't perform the
> selector matching to determine whether there is a ::before / ::after rule
> that matches the element?

I'd think we could simply set the bit from servo during traversal, no?

Comment 3

[Cameron McCormack (:heycam)]

Of course, yes. :-)

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This is not an issue anymore.