Open Bug 1296492 Opened 3 years ago Updated Last year

[Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html

Categories

(Core :: DOM: Events, defect, P3)

defect

Tracking

()

People

(Reporter: stone, Assigned: stone)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 6 obsolete files)

2.75 KB, patch
stone
: review+
Details | Diff | Splinter Review
5.38 KB, patch
stone
: review+
Details | Diff | Splinter Review
No description provided.
Depends on: 1296185
Priority: -- → P2
Assignee: nobody → sshih
Depends on: 1304290
This test case need to synthesize native touch events because it needs APZ to fire compatible mouse events to trigger mouse transition events.
Attachment #8793655 - Flags: feedback?(btseng)
Comment on attachment 8793653 [details] [diff] [review]
[Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V1)

Review of attachment 8793653 [details] [diff] [review]:
-----------------------------------------------------------------

Please correct the issue in-lined, thanks!

::: dom/events/test/pointerevents/test_pointerevent_multiple_primary_pointers_boundary_events-manual.html
@@ +18,4 @@
>        }
>        function executeTest(int_win) {
> +        int_win.document.getElementById("target1").addEventListener("mouseenter", function continueFireEvents() {
> +          int_win.document.getElementById("target1").addEventListener("mouseenter", continueFireEvents, false);

I think you are supposed to remove the continueFireEvents() from EventListener instead. :)
Comment on attachment 8793655 [details] [diff] [review]
[Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V1)

Review of attachment 8793655 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/test/pointerevents/test_pointerevent_multiple_primary_pointers_boundary_events-manual.html
@@ +18,4 @@
>        }
>        function executeTest(int_win) {
> +        int_win.document.getElementById("target1").addEventListener("mouseenter", function continueFireEvents() {
> +          int_win.document.getElementById("target1").addEventListener("mouseenter", continueFireEvents, false);

I think you are supposed to remove the continueFireEvents() from EventListener instead.
Attachment #8793655 - Flags: feedback?(btseng)
We need to synthesize native touch events to let APZ to fire mouse events for this test case.
Attachment #8797046 - Flags: feedback?(btseng)
Attachment #8797046 - Flags: feedback?(btseng) → feedback+
Add supported files in mochitest.ini
Attachment #8797046 - Attachment is obsolete: true
Attachment #8798270 - Flags: feedback+
This patch synthesize native touch event. It's worked on non-e10s and no-windows environment. I create another test to synthesize mouse events with input source = touch. But this test need to synthesize events with pointer id. As I know, Ben is handling new API with pointer id supported. Would like to continue this bug after that.
When firing synthesized native touch events, we should ignore the checks to testing pointer id because it is automatically generated by widget code.
Attachment #8798270 - Attachment is obsolete: true
We need to use synthesized native touch events so that apz can generate corresponding mouse events for us to run this test correctly. We can't use callback of synthesizeNativeTap to synthesize the subsequent mouse events because the touch generated mouse events are fired after the callback is invoked.
Attachment #8843866 - Flags: review?(bugs)
Attachment #8843868 - Flags: review?(bugs)
Attachment #8843866 - Flags: review?(bugs) → review+
Comment on attachment 8843868 [details] [diff] [review]
Part2: Investigate failure of test_pointerevent_multiple_primary_pointers_boundary_events-manual.html

Commit message could perhaps tell in the first line what it is fixing.

rs+
Attachment #8843868 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/801cde6d6c3c
Part1: Refine PE mochitest helpers to ignore the checks of synthesized pointer id. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5a2225f267d
Part2: Synthesize native touch events to trigger pointerevent_multiple_primary_pointers_boundary_events-manual.html. r=smaug
Keywords: checkin-needed
sorry had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=85035272&repo=mozilla-inbound
Flags: needinfo?(sshih)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e32d48f0a7
Backed out changeset b5a2225f267d 
https://hg.mozilla.org/integration/mozilla-inbound/rev/94e295b0a815
Backed out changeset 801cde6d6c3c for test failures in pointerevent_multiple_primary_pointers_boundary_events-manual.html
Oops. Don't know why the mouse is hovering on target1 when starting the test. Trying to reproduce it with my local build.
Flags: needinfo?(sshih)
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.