1296492 - [Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: [Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V1)

This test case need to synthesize native touch events because it needs APZ to fire compatible mouse events to trigger mouse transition events.

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: [Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V1)

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8793653 [details] [diff] [review]
[Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V1)

Review of attachment 8793653 [details] [diff] [review]:
-----------------------------------------------------------------

Please correct the issue in-lined, thanks!

::: dom/events/test/pointerevents/test_pointerevent_multiple_primary_pointers_boundary_events-manual.html
@@ +18,4 @@
>        }
>        function executeTest(int_win) {
> +        int_win.document.getElementById("target1").addEventListener("mouseenter", function continueFireEvents() {
> +          int_win.document.getElementById("target1").addEventListener("mouseenter", continueFireEvents, false);

I think you are supposed to remove the continueFireEvents() from EventListener instead. :)

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8793655 [details] [diff] [review]
[Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V1)

Review of attachment 8793655 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/test/pointerevents/test_pointerevent_multiple_primary_pointers_boundary_events-manual.html
@@ +18,4 @@
>        }
>        function executeTest(int_win) {
> +        int_win.document.getElementById("target1").addEventListener("mouseenter", function continueFireEvents() {
> +          int_win.document.getElementById("target1").addEventListener("mouseenter", continueFireEvents, false);

I think you are supposed to remove the continueFireEvents() from EventListener instead.

Comment 5

[Ming-Chou Shih [:stone]]

Attachment: Bug 1296492 - [Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V2)

Refined patch and rebased

Comment 6

[Ming-Chou Shih [:stone]]

We need to synthesize native touch events to let APZ to fire mouse events for this test case.

Comment 7

[Ming-Chou Shih [:stone]]

Attachment: Bug 1296492 - [Pointer Event] Investigate failure of pointerevent_multiple_primary_pointers_boundary_events-manual.html (V3)

Add supported files in mochitest.ini

Comment 8

[Ming-Chou Shih [:stone]]

This patch synthesize native touch event. It's worked on non-e10s and no-windows environment. I create another test to synthesize mouse events with input source = touch. But this test need to synthesize events with pointer id. As I know, Ben is handling new API with pointer id supported. Would like to continue this bug after that.

Comment 9

[Ming-Chou Shih [:stone]]

Attachment: Part1: Refine PE mochitest helpers to ignore the checks of synthesized pointer id

When firing synthesized native touch events, we should ignore the checks to testing pointer id because it is automatically generated by widget code.

Comment 10

[Ming-Chou Shih [:stone]]

Attachment: Part2: Investigate failure of test_pointerevent_multiple_primary_pointers_boundary_events-manual.html

We need to use synthesized native touch events so that apz can generate corresponding mouse events for us to run this test correctly. We can't use callback of synthesizeNativeTap to synthesize the subsequent mouse events because the touch generated mouse events are fired after the callback is invoked.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8843868 [details] [diff] [review]
Part2: Investigate failure of test_pointerevent_multiple_primary_pointers_boundary_events-manual.html

Commit message could perhaps tell in the first line what it is fixing.

rs+

Comment 12

[Ming-Chou Shih [:stone]]

Attachment: Part1: Refine PE mochitest helpers to ignore the checks of synthesized pointer id

Comment 13

[Ming-Chou Shih [:stone]]

Attachment: Part2: Investigate failure of test_pointerevent_multiple_primary_pointers_boundary_events-manual.html

Comment 14

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=145479a22ba23b33ef0a64911007ea1a1346a5c4

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/801cde6d6c3c
Part1: Refine PE mochitest helpers to ignore the checks of synthesized pointer id. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5a2225f267d
Part2: Synthesize native touch events to trigger pointerevent_multiple_primary_pointers_boundary_events-manual.html. r=smaug

Comment 16

[Carsten Book [:Tomcat]]

sorry had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=85035272&repo=mozilla-inbound

Comment 17

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e32d48f0a7
Backed out changeset b5a2225f267d 
https://hg.mozilla.org/integration/mozilla-inbound/rev/94e295b0a815
Backed out changeset 801cde6d6c3c for test failures in pointerevent_multiple_primary_pointers_boundary_events-manual.html

Comment 18

[Ming-Chou Shih [:stone]]

Oops. Don't know why the mouse is hovering on target1 when starting the test. Trying to reproduce it with my local build.

Comment 19

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:hsinyi, could you have a look please?
For more information, please visit auto_nag documentation.