js-config contains the python representation of a list for NSPR_CFLAGS

RESOLVED FIXED in Firefox 51

Status

()

Core
Build Config
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
NSPR_CFLAGS='['-I(...)/obj-x86_64-pc-linux-gnu/dist/include/nspr']'

is what this looks like in js-config. This is a regression from bug 1229541.

The problem is that we're feeding raw substs values to the preprocessor:
https://dxr.mozilla.org/mozilla-central/rev/97a52326b06a07930216ebefa5af333271578904/python/mozbuild/mozbuild/backend/base.py#244

The preprocessor then goes on to convert the values to strings when apply the substitution filter:
https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/preprocessor.py#728
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8782736 [details]
Bug 1296502 - Serialize lists when preparing a context for the preprocessor in build backends.

https://reviewboard.mozilla.org/r/72784/#review70700
Attachment #8782736 - Flags: review?(gps) → review+

Comment 3

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/c3edbba2eb8a
Serialize lists when preparing a context for the preprocessor in build backends. r=gps

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c3edbba2eb8a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.