If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Rename some method names which look for an editable node

NEW
Unassigned

Status

()

Core
Editor
P3
normal
a year ago
11 months ago

People

(Reporter: masayuki, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox51 affected)

Details

Some methods in editor look for a editable node, but it's not explained by the method name. So, we should rename them as:

* HTMLEditor::GetNextHTMLNode() -> HTMLEditor::GetNextEditableNode()
* HTMLEditor::GetPriorHTMLNode() -> HTMLEditor::GetPrevEditableNode()
* HTMLEditor::GetNextHTMLSibling() -> HTMLEditor::GetNextEditableSibling()
* HTMLEditor::GetPriorHTMLSibling() -> HTMLEditor::GetPrevEditableSibling()

(I like "Prev" better than "Prior" because a lot of code use it as opposite word of "Next" and it's same length as "Next".)
The first two also only return leaf nodes, which is practically speaking an even more critical detail, so I suggest GetPrev/NextEditableLeafNode() for the first two.  Otherwise agreed.
Thanks you. I'll suggest to use this bug in Hacker event of Mozilla Japan at this weekend.
(Reporter)

Updated

11 months ago
Blocks: 1311232

Updated

11 months ago
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.