1296512 - Rework OriginScope to use a union

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Varga [:janv]]

Attachment: patch

This is needed to make adding of new types more efficient since specific types only need a subset of member variables.

Bug 1278037 depends on this.

try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=178b40588834

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a3c14d1770f
Rework OriginScope to use a union; r=asuth

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for 'Conditional jump or move depends on uninitialised value(s)' detected by valgrind:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c9d2e4cb79acf86a2e0b3d5519842fc62cec6af

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7a3c14d1770f8e3f3811642455e144741e9ff67a
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=34314747&repo=mozilla-inbound

TEST-UNEXPECTED-FAIL | valgrind-test | Conditional jump or move depends on uninitialised value(s) at mozilla::dom::quota::OriginScope::Destroy / mozilla::dom::quota::OriginScope::OriginScope / mozilla::dom::quota::DirectoryLockImpl::DirectoryLockImpl / mozilla::dom::quota::QuotaManager::CreateDirectoryLock

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Ah, right, the copy constructor probably really doesn't want to have Destroy() as its first line.  (Or at all.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d512ff46343
Rework OriginScope to use a union; r=asuth

Comment 5

[Jan Varga [:janv]]

(In reply to Andrew Sutherland [:asuth] from comment #3)
> Ah, right, the copy constructor probably really doesn't want to have
> Destroy() as its first line.  (Or at all.)

Yeah, I removed it.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d512ff46343