Closed
Bug 1296512
Opened 9 years ago
Closed 8 years ago
Rework OriginScope to use a union
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
Details
Attachments
(1 file)
7.12 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
This is needed to make adding of new types more efficient since specific types only need a subset of member variables.
Bug 1278037 depends on this.
try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=178b40588834
Assignee | ||
Updated•9 years ago
|
Attachment #8782742 -
Attachment is patch: true
Attachment #8782742 -
Flags: review?(bugmail)
Assignee | ||
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8782742 -
Flags: review?(bugmail) → review+
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a3c14d1770f
Rework OriginScope to use a union; r=asuth
![]() |
||
Comment 2•8 years ago
|
||
Backed out for 'Conditional jump or move depends on uninitialised value(s)' detected by valgrind:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c9d2e4cb79acf86a2e0b3d5519842fc62cec6af
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7a3c14d1770f8e3f3811642455e144741e9ff67a
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=34314747&repo=mozilla-inbound
TEST-UNEXPECTED-FAIL | valgrind-test | Conditional jump or move depends on uninitialised value(s) at mozilla::dom::quota::OriginScope::Destroy / mozilla::dom::quota::OriginScope::OriginScope / mozilla::dom::quota::DirectoryLockImpl::DirectoryLockImpl / mozilla::dom::quota::QuotaManager::CreateDirectoryLock
Flags: needinfo?(jvarga)
Comment 3•8 years ago
|
||
Ah, right, the copy constructor probably really doesn't want to have Destroy() as its first line. (Or at all.)
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d512ff46343
Rework OriginScope to use a union; r=asuth
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Andrew Sutherland [:asuth] from comment #3)
> Ah, right, the copy constructor probably really doesn't want to have
> Destroy() as its first line. (Or at all.)
Yeah, I removed it.
Flags: needinfo?(jvarga)
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•