1296582 - [Static Analysis][Uninitialised members] In constructor SurfaceDescriptorX11

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that an Uninitialized pointer read pointer read can happen in the following context:

>>            SurfaceDescriptorX11 tmp = SurfaceDescriptorX11();
>>            (*(v__)) = tmp;
>>            if ((!(Read((&((v__)->get_SurfaceDescriptorX11())), msg__, iter__)))) {

This can happen since the members from tmp are not initialised in their contractor. Even this is a false-positive since the data will be overwritten in the Read function we should still initialise it in order to comply with our clang based static analysis tool that search for uninitialised member variables.

Comment 1

[Andi [:andi]]

Attachment: Bug 1296582 - ignore initialisation check for members in SurfaceDescriptorX11.

Review commit: https://reviewboard.mozilla.org/r/72882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72882/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8782848 [details]
Bug 1296582 - ignore initialisation check for members in SurfaceDescriptorX11.

https://reviewboard.mozilla.org/r/72882/#review71196

Let's annotate these as uninitialized instead.

Comment 3

[Andi [:andi]]

Comment on attachment 8782848 [details]
Bug 1296582 - ignore initialisation check for members in SurfaceDescriptorX11.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72882/diff/1-2/

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8782848 [details]
Bug 1296582 - ignore initialisation check for members in SurfaceDescriptorX11.

https://reviewboard.mozilla.org/r/72882/#review71692

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79c7fe81fe5a
ignore initialisation check for members in SurfaceDescriptorX11. r=jrmuizel

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/79c7fe81fe5a