1296692 - Clean up and refactoring of Perfherder internals: compare view, models, services

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

Angular components are easier to understand and reason about than directives, let's try using them for the compare view. :)

Comment 1

[William Lachance (:wlach)]

Being able to use components depends on us upgrading to Angular 1.5.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1296692 > mozilla:master

Comment 3

[William Lachance (:wlach)]

This bug has morphed a bit into some general cleanup, which was long overdue but made more important by the fact that people are now trying to work with and extend the comparison views.

This is work is rather involved and boring, so I just took it on myself.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8782987 [details] [review]
[treeherder] wlach:1296692 > mozilla:master

Hey :rwood, :ShrutiJ... I would like your feedback on these changes, if you have a moment or two this week. My hope is that these modifications will make your work easier.

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8782987 [details] [review]
[treeherder] wlach:1296692 > mozilla:master

This looks GREAT!

Much cleaner than having so much in perf.js. From my novice angular.js knowledge, it LGTM. Not sure about the binding directions (some where changed to one-way bindings) as I don't really know what the implication of that is.

I'm just assuming you found all the places in the html where bindings that used to be referenced naturally by scope are now referenced by their corresponding component ctrl.* :)

Comment 6

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8782987 [details] [review]
[treeherder] wlach:1296692 > mozilla:master

I agree with :rwood. This clean up has made the code way more easy to understand.

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9cd7df200e074b748bd7034c24959172229159d6
Bug 1296692 - Transition compare perf controller to use angular components

https://github.com/mozilla/treeherder/commit/86bc65d8f35606bf16aa2c6755104de518ade819
Bug 1296692 - Move displayPrecision filter to ui/js/filters.js

There's nothing really perfherder specific about this filter (I'm planning
to use it for Infraherder) and filters.js is a more natural place for it.

https://github.com/mozilla/treeherder/commit/98952774b945f111590ec044df85a924ac727714
Bug 1296692 - Move series/compare/math models/factories to their own files

These are big enough that they deserve their own files, especially
the compare service.

https://github.com/mozilla/treeherder/commit/ea3c7efbb12dd2c6b744640589098decfeccea11
Merge pull request #1800 from wlach/1296692

Bug 1296692 - Transition compare perf controller to use angular components