Closed Bug 1296723 Opened 5 years ago Closed 3 years ago

Remove logOncePerBrowserVersion telemetry functions and probes

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: clarkbw, Assigned: miker)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

in bug 1250171 we removed the *_PER_USER_FLAG probes and as was pointed out in bug 1250171 comment 10 the system is pretty hacky.  The logOncePerBrowserVersion function is the base of that system and is no longer needed.

I'm currently reviewing the remaining probes in: 
https://dxr.mozilla.org/mozilla-central/search?q=logOncePerBrowserVersion

https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/views/Longitudinal.scala#L194

* OS_HISTOGRAM : already available : system_os.[name/version]
* OS_IS_64_BITS : already available : system.is_wow64 
* SCREENSIZE_HISTOGRAM : already available : monitors : [ monitor : { screen_width, screen_height }]
Severity: normal → enhancement
Priority: -- → P3
Assignee: nobody → mratcliffe
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
OS: Unspecified → All
Hardware: Unspecified → All
The only place we were still using logOncePerBrowserVersion is for DEVTOOLS_SCREEN_RESOLUTION_ENUMERATED_PER_USER but if that is available in monitors : [ monitor : { screen_width, screen_height }] we should be fine to delete it.

The same data is also available in event telemetry.

@digitarald Is that okay with you... we really need to remove this hacky method.
Flags: needinfo?(hkirschner)
Summary: remove logOncePerBrowserVersion telemetry functions and probes → Remove logOncePerBrowserVersion telemetry functions and probes
Attachment #8974345 - Attachment is obsolete: true
digitarald confirms it is fine to remove this probe.
Flags: needinfo?(hkirschner)
Status: NEW → ASSIGNED
Attachment #8974352 - Attachment is obsolete: true
Comment on attachment 8974392 [details]
Bug 1296723 - Remove logOncePerBrowserVersion telemetry functions and probes

https://reviewboard.mozilla.org/r/242742/#review248556

Try is green
Review ping.
Flags: needinfo?(jryans)
(In reply to Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] from comment #11)
> Review ping.

Sorry for the delay; I was on PTO May 10 - 14.
Flags: needinfo?(jryans)
Comment on attachment 8974392 [details]
Bug 1296723 - Remove logOncePerBrowserVersion telemetry functions and probes

https://reviewboard.mozilla.org/r/242742/#review250104

Thanks, this looks good to me! :)
Attachment #8974392 - Flags: review?(jryans) → review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f755fe79a51b
Remove logOncePerBrowserVersion telemetry functions and probes r=jryans
https://hg.mozilla.org/mozilla-central/rev/f755fe79a51b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
Depends on: 1491007
You need to log in before you can comment on or make changes to this bug.