Closed Bug 1296740 Opened 4 years ago Closed 4 years ago

clang-cl warning: unintended name hiding in {gfxFontFamily,gfxDWriteFontFamily}::ReadFaceNames

Categories

(Core :: Graphics: Text, defect)

All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: froydnj, Assigned: jfkthame)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

clang-cl complains thusly:

 4:16.98 In file included from C:/m-c/obj-clang-cl-optimized/gfx/thebes/Unified_cpp_gfx_thebes0.cpp:83:
 4:16.98 In file included from c:/m-c/gfx/thebes/gfxDWriteFontList.cpp:9:
 4:16.98 c:/m-c/gfx/thebes/gfxDWriteFontList.h(50,18):  warning: 'gfxDWriteFontFamily::ReadFaceNames' hides overloaded virtual function [-Woverloaded-virtual]
 4:16.98     virtual void ReadFaceNames(gfxPlatformFontList *aPlatformFontList,
 4:16.98                  ^
 4:16.98 c:/m-c/gfx/thebes/gfxFontEntry.h(755,18):  note: hidden overloaded virtual function 'gfxFontFamily::ReadFaceNames' declared here: different number of parameters (3 vs 2)
 4:16.98     virtual void ReadFaceNames(gfxPlatformFontList *aPlatformFontList,
 4:16.98                  ^

Maybe the gfxDWriteFontFamily version doesn't need to be declared virtual...or it unintentionally doesn't match the function in its superclass?
Component: Graphics → Graphics: Text
Flags: needinfo?(jfkthame)
Whiteboard: [gfx-noted]
It looks to me like this was just overlooked when the async font loader code was originally implemented in bug 962440. It's harmless, AFAICT, but makes the code unnecessarily confusing to the human reader.
Attachment #8783552 - Flags: review?(jmuizelaar)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8783552 - Flags: review?(jmuizelaar) → review+
Flags: needinfo?(jfkthame)
https://hg.mozilla.org/integration/mozilla-inbound/rev/88220a647d317317b594f5694b5fecf6fb4a23d7
Bug 1296740 - Fix the parameter list for the gfxDWriteFontFamily implementation of ReadFaceNames. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/88220a647d31
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.