Closed
Bug 1296744
Opened 8 years ago
Closed 8 years ago
Make cameraCallbackBridge use new JNI native bindings
Categories
(Core Graveyard :: Widget: Android, defect, P3)
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(2 files)
|
14.15 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
|
7.48 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
GeckoAppShell.cameraCallbackBridge is the last user of the old JNI bindings in jni-stubs.inc. We should convert it to the new bindings, so we can remove the old bindings and the old binding generator.
|
||
Updated•8 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•8 years ago
|
||
Make the GeckoAppShell.cameraCallbackBridge callback use the new native JNI bindings. Also refactor the relevant code in GeckoAppShell and CameraStreamImpl.
Attachment #8784556 -
Flags: review?(snorp)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8784558 -
Flags: review+
Attachment #8784556 -
Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/da87045db580 Make cameraCallbackBridge use new native JNI bindings; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/f2786b15fa37 Update auto-generated bindings; r=me
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/da87045db580 https://hg.mozilla.org/mozilla-central/rev/f2786b15fa37
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•