Closed Bug 1296750 Opened 3 years ago Closed 3 years ago

Crash in java.util.NoSuchElementException: at java.util.TreeMap$MapIterator.stepForward(TreeMap.java)

Categories

(Firefox for Android :: General, defect, P3, critical)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox50 + fixed
firefox51 + fixed

People

(Reporter: ahunt, Assigned: ahunt)

Details

(Keywords: crash, Whiteboard: [MobileAS])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-ef3b8335-6634-4b3e-88ec-f21962160818.
=============================================================
This seems to be quite high on Aurora, let's fix it!
Assignee: nobody → ahunt
[Tracking Requested - why for this release]: 7th top crash on Aurora.
Comment on attachment 8783067 [details]
Bug 1296750 - Don't crash if multiple files have same timestamp in TelemetryJSONFilePingStore.deleteSmallestFiles

https://reviewboard.mozilla.org/r/73032/#review70826

Looks good, but same as you I have no idea if this sort of a thing should even happen in the first place. Perhaps file a follow up bug to investigate?
Attachment #8783067 - Flags: review?(gkruglov) → review+
Whiteboard: [MobileAS]
Hello Andrzej, the patch has been r+d. Are we ready to land it on Nightly soon and stabilize followed by uplifting to Aurora50?
Flags: needinfo?(ahunt)
Priority: -- → P3
Pushed by ahunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/179f3c125af2
Don't crash if multiple files have same timestamp in TelemetryJSONFilePingStore.deleteSmallestFiles r=Grisha
(In reply to Ritu Kothari (:ritu) from comment #5)
> Hello Andrzej, the patch has been r+d. Are we ready to land it on Nightly
> soon and stabilize followed by uplifting to Aurora50?

Landed now! Since we're seeing this primarily on aurora (only 2 crashes on nightly) I'll request uplift so we can see whether it fixes the issues there.
Flags: needinfo?(ahunt)
Comment on attachment 8783067 [details]
Bug 1296750 - Don't crash if multiple files have same timestamp in TelemetryJSONFilePingStore.deleteSmallestFiles

Approval Request Comment
[Feature/regressing bug #]: Bug 1270213
[User impact if declined]: Seemingly random crash when telemtry files are cleaned up, in certain scenarios (multiple files with the same timestamp, and more files being deleted than there are unique timestamps).
[Describe test coverage new/current, TreeHerder]: Manual testing locally.
[Risks and why]: Low risk: a sorted set has been replaced with a sorted list, remaining code functions the same regardless of the underlying collection in use.
[String/UUID change made/needed]: none.
Attachment #8783067 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/179f3c125af2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8783067 [details]
Bug 1296750 - Don't crash if multiple files have same timestamp in TelemetryJSONFilePingStore.deleteSmallestFiles

This crash does not have enough volume on Nightly for verification purposes. Let's uplift to Aurora50 to confirm whether it's fixed or not.
Attachment #8783067 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.