Closed
Bug 1296802
Opened 8 years ago
Closed 8 years ago
Telemetry pings are run through the URL Classifier
Categories
(Toolkit :: Safe Browsing, defect, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: francois, Assigned: tnguyen)
References
Details
(Whiteboard: #sbv4-m3)
Attachments
(1 file)
After running Firefox with the MOZ_LOG="UrlClassifierDbService:5,nsChannelClassifier:5" envvar set, I noticed the following: [URL Classifier]: D/UrlClassifierDbService Checking fragment telemetry.mozilla.org/submit/telemetry/daf169db-afb9-4cbd-83d2-3c97cd049eae/saved-session/Firefox/51.0a1/nightly/20160819080504?v=4, hash 2C24B4800FC8CB168F8CB9A8FAF9D13C7B43EDDC7EBEBC6882389F851EF4A6FB (80B4242C) which means that we are erroneously running telemetry pings through the URL Classifier. We shouldn't do this because we would miss any telemetry related to telemetry URLs getting mistakenly added to one of the Safe Browsing lists.
Updated•8 years ago
|
Whiteboard: [sb-backlog] [sb-moderate]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → tnguyen
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8795406 [details] Bug 1296802 - remove LOAD_CLASSIFY_URI flag to prevent telemetry pings from running through the URL Classifier. https://reviewboard.mozilla.org/r/81464/#review80032 Looks good! I would suggest changing the comment to: // Prevent the request channel from running though URLClassifier (bug 1296802)
Attachment #8795406 -
Flags: review?(francois) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a50e4118100c
Assignee | ||
Comment 5•8 years ago
|
||
There's a timeout failure in try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=a50e4118100c&selectedJob=28118291
Updated•8 years ago
|
Whiteboard: #sbv4-m2 → #sbv4-m3
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=327f28bd4f2a
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b237c4dc627
Assignee | ||
Comment 8•8 years ago
|
||
Taking a look at the timeout log. It's the same as issue bug 1164562. Timeout in test_disableDataUpload of test_TelemetryController.js
Assignee | ||
Comment 9•8 years ago
|
||
There's a race condition in TelemetrySend and test_TelemetryController.js submit the old telemetry. I will take the bug 1164562 first and come back this soon.
Assignee | ||
Comment 10•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f658bd4ea8b6&selectedJob=29979733
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 12•8 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1565fbf6835 remove LOAD_CLASSIFY_URI flag to prevent telemetry pings from running through the URL Classifier. r=francois
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e1565fbf6835
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•