Closed Bug 1296802 Opened 3 years ago Closed 3 years ago

Telemetry pings are run through the URL Classifier

Categories

(Toolkit :: Safe Browsing, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: francois, Assigned: tnguyen)

References

Details

(Whiteboard: #sbv4-m3)

Attachments

(1 file)

After running Firefox with the MOZ_LOG="UrlClassifierDbService:5,nsChannelClassifier:5" envvar set, I noticed the following:

[URL Classifier]: D/UrlClassifierDbService Checking fragment telemetry.mozilla.org/submit/telemetry/daf169db-afb9-4cbd-83d2-3c97cd049eae/saved-session/Firefox/51.0a1/nightly/20160819080504?v=4, hash 2C24B4800FC8CB168F8CB9A8FAF9D13C7B43EDDC7EBEBC6882389F851EF4A6FB (80B4242C)

which means that we are erroneously running telemetry pings through the URL Classifier.

We shouldn't do this because we would miss any telemetry related to telemetry URLs getting mistakenly added to one of the Safe Browsing lists.
Whiteboard: [sb-backlog] [sb-moderate]
Assignee: nobody → tnguyen
Blocks: 116703
Whiteboard: [sb-backlog] [sb-moderate] → #sbv4-m2
Status: NEW → ASSIGNED
Comment on attachment 8795406 [details]
Bug 1296802 - remove LOAD_CLASSIFY_URI flag to prevent telemetry pings from running through the URL Classifier.

https://reviewboard.mozilla.org/r/81464/#review80032

Looks good!

I would suggest changing the comment to:

    // Prevent the request channel from running though URLClassifier (bug 1296802)
Attachment #8795406 - Flags: review?(francois) → review+
Whiteboard: #sbv4-m2 → #sbv4-m3
Taking a look at the timeout log. It's the same as issue bug 1164562. Timeout in test_disableDataUpload of test_TelemetryController.js
There's a race condition in TelemetrySend and test_TelemetryController.js submit the old telemetry.
I will take the bug 1164562 first and come back this soon.
Depends on: 1164562
Keywords: checkin-needed
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1565fbf6835
remove LOAD_CLASSIFY_URI flag to prevent telemetry pings from running through the URL Classifier. r=francois
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e1565fbf6835
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.