Dimmed background is not correct

VERIFIED FIXED in Firefox 51

Status

()

Toolkit
Find Toolbar
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Alice0775 White, Assigned: mikedeboer)

Tracking

(Blocks: 1 bug, {regression})

51 Branch
mozilla51
x86
Windows 10
regression
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox50 unaffected, firefox51 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

a year ago
Created attachment 8783141 [details]
screenshot

Steps To Reproduce:
1. Enable new findbar
  user_pref("findbar.highlightAll", true);
  user_pref("findbar.modalHighlight", true);
2. Open Wikipedia
   (e.g. https://en.wikipedia.org/wiki/Firefox )
3. Open Find Bar (Ctrl+F)
4. Type "mozilla" (without quotation marks) in the Find Bar
5. Scroll down

Actual Results:
Dimmed background does not render to the entire page.
i.e. Dimmed background is not enough width and height.

Expected Results:
Dimmed background should render over the entire page

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=2edc35144ebf50ca6339e686e766e200cc4b04b8&tochange=f76b9d417a3678f840f498598d215b41f5c6616a

Suspect:
69c852865f06	Mike de Boer — Bug 1290913 - prevent flushing the layout when dimmed highlight background is constructed. r=jaws

Comment 1

a year ago
This has been corrected
(Reporter)

Comment 2

a year ago
(In reply to kalevibaik from comment #1)
> This has been corrected

No, This is not fixed yet.
status-firefox50: --- → unaffected
(Reporter)

Comment 3

a year ago
Bug 1279695 does not fix the problem...

STR.
1. Enable new findbar
  user_pref("findbar.highlightAll", true);
  user_pref("findbar.modalHighlight", true);
2. Open Wikipedia
   (e.g. https://en.wikipedia.org/wiki/Firefox )
3. Resize browser window to w=640px, H=850px,  so that horizontal and vertical scroll bar appear.
4. Open Find Bar (Ctrl+F)
5. Type "mozilla" (without quotation marks) in the Find Bar
   --- observe, Dimmed background size
6. Scroll down
   --- observe, Dimmed background size

Actual Results:
Dimmed background does not render to the entire page.
i.e. Dimmed background is not enough Width and Height.
Depends on: 1279695
(Reporter)

Updated

a year ago
Blocks: 1291278
No longer depends on: 1279695
(In reply to Alice0775 White from comment #3)
> Bug 1279695 does not fix the problem...

Well, this has only just merged into mozilla-central, so there's no Nighly build out yet with this in it.
Can you try it with tomorrow's Nightly?
Flags: needinfo?(alice0775)
(Reporter)

Comment 5

a year ago
(In reply to Mike de Boer [:mikedeboer] from comment #4)
> (In reply to Alice0775 White from comment #3)
> > Bug 1279695 does not fix the problem...
> 
> Well, this has only just merged into mozilla-central, so there's no Nighly
> build out yet with this in it.
> Can you try it with tomorrow's Nightly?

I have tested latest fx-team build. So the Bug 1279695 is included.
Flags: needinfo?(alice0775)
(Reporter)

Comment 6

a year ago
Created attachment 8785390 [details]
screenshot

Gap at bottom and right side

tested on
https://hg.mozilla.org/mozilla-central/rev/a65b35c8e5b17c2585968974aef1da67a8c56642
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 ID:20160826063819
(In reply to Alice0775 White from comment #6)
> Gap at bottom and right side

Aha! That's easy to fix - I'm accounting for the scrollbar width on both sides, but that's not necessary anymore since I'm using `getRootBounds()` now.
Thanks for the screenshot!
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 51.2 - Aug 29
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
Comment hidden (mozreview-request)

Comment 9

a year ago
mozreview-review
Comment on attachment 8785593 [details]
Bug 1296822 - ignore the scrollbar size when nsIDOMWindowUtils.getRootBounds is used when fetching the page size for the findbar.

https://reviewboard.mozilla.org/r/74746/#review72988
Attachment #8785593 - Flags: review?(jaws) → review+

Comment 10

a year ago
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74516f0a4d8a
ignore the scrollbar size when nsIDOMWindowUtils.getRootBounds is used when fetching the page size for the findbar. r=jaws

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/74516f0a4d8a
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Verified as fixed on Windows, Ubuntu and Mac OS X on the latest Nightly 52.0a1 Build ID:20160922030437
Status: RESOLVED → VERIFIED
status-firefox51: fixed → verified
You need to log in before you can comment on or make changes to this bug.