Closed Bug 1296839 Opened 3 years ago Closed 3 years ago

Minor Tabbrowser.xml cleanups and changes

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set

Tracking

(seamonkey2.52 fixed)

RESOLVED FIXED
seamonkey2.52
Tracking Status
seamonkey2.52 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(3 files)

Some changes I did during working on various bugs.
Comment only update
Attachment #8783180 - Flags: review?(philip.chee)
Port getbrowsercontainer method. Prerequisite for making Devtools Responsive Design View work. This will need additional changes but it doesn't complain any longer about the missing function.
Attachment #8783181 - Flags: review?(philip.chee)
Bring internal progress handling in line with Firefox. Variables were either not used or bogus anyway. The call to _callProgressListeners(null, "onProgressChange" is not right because progress doesn't change here.
Attachment #8783182 - Flags: review?(philip.chee)
Attachment #8783180 - Flags: review?(philip.chee) → review+
Comment on attachment 8783181 [details] [diff] [review]
1296839-getbrowsercontainer.patch

This does not work because we don't have a "browserContainer" element like Firefox: https://hg.mozilla.org/mozilla-central/annotate/0534254e9a40/browser/base/content/tabbrowser.xml#l25
Attachment #8783181 - Flags: review?(philip.chee) → review-
(In reply to Frank-Rainer Grahl from comment #2)
> Created attachment 8783181 [details] [diff] [review]
> 1296839-getbrowsercontainer.patch
> 
> Port getbrowsercontainer method. Prerequisite for making Devtools Responsive
> Design View work. This will need additional changes but it doesn't complain
> any longer about the missing function.
But it will complain about something else right?
>> But it will complain about something else right?

Yes. Some exception. Was just a quick fix to get at least rid of the missing function.
Comment on attachment 8783182 [details] [diff] [review]
1296839-progressupdate.patch

Redirecting review.
Attachment #8783182 - Flags: review?(philip.chee) → review?(iann_bugzilla)
Comment on attachment 8783182 [details] [diff] [review]
1296839-progressupdate.patch

Is it worth doing the method _callProgressListeners whilst you are here?
Attachment #8783182 - Flags: review?(iann_bugzilla) → review+
> Is it worth doing the method _callProgressListeners whilst you are here?

It was straight from the Fx tabbrowser.xml. There it does nothing because onProgressChange in browser.js is empty. But we have code in the corresponding function in nsBrowserStatusHandler.js so I would say yes or we would probably have problems with the status bar meter.
1296839-progressupdate.patch:
https://hg.mozilla.org/comm-central/rev/451a2b98d1f364d3b88c84a00e42f61c18635bf1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.52
You need to log in before you can comment on or make changes to this bug.