1296882 - WebExtensions should not be subject to the popup blocker

Status: REOPENED

(WebExtensions :: General, defect, P3)

Description

[dteviot]

Attachment: Minimal extension to demonstrate behaviour.

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce:

I have a Web Extension.
If I call Window.open() in response to a user clicking a button, it works.
If I call Window.open() in the callback to, say, chrome.tabs.query() no window opens.

Example code
```javascript
    function onOpenWindowWithClickButton() {
        let url = chrome.extension.getURL("tab.html");
        window.open(url, "_blank");
    }

    function onOpenWindowWithCallbackButton() {
        chrome.tabs.query({ currentWindow: true, active: true }, function (tabs) { 
            onOpenWindowWithClickButton();
        });
    }

    // actions to do when window opened
    window.onload = function () {
        // add onClick event handlers
        document.getElementById("openWindowWithClickButton").onclick = onOpenWindowWithClickButton;
        document.getElementById("openWindowWithCallbackButton").onclick = onOpenWindowWithCallbackButton;
    }
```

Attached is minimal extension to demonstrate behaviour.
Problem occurs on both Firefox 48 and 50.



Actual results:

No window appears when call Window.open in callback.


Expected results:

Window should be created

Comment 1

[Kris Maglione [:kmag]]

This is because the popup blocker only allows window.open to be called in direct response to user interaction. If you want to open a window asynchronously, you can use browser.windows.create or browser.tabs.create.