1296895 - Closing private browsing cancels downloads without a warning

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Download Manager, defect, P3)

Description

[Michael Smith [:mismith] (non-bmo mail: [e-mail])]

On desktop trying to close the last Private Browsing tab produces a warning that this will cancel downloads in progress. Firefox for Android just cancels them silently.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

@antlam: Any thoughts from UX?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Smith [:mismith] from comment #0)
> On desktop trying to close the last Private Browsing tab produces a warning
> that this will cancel downloads in progress. Firefox for Android just
> cancels them silently.

Is the download triggered from the private tab that's being closed?

If so, a simple dialog to confirm this would make sense. Can I see a screenshot? I can work on the copy with Michelle in the meantime

(NI'ing Michelle for thoughts :)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Anthony Lam (:antlam) from comment #2)
> Is the download triggered from the private tab that's being closed?

This doesn't really matter: As long as you have at least one private tab open, the download will continue. However as soon as you close the last private tab (-> end the private browsing session) the "private" downloads will be cancelled. All downloads started from normal tabs are not affected.

Comment 4

[mheubusch]

Hi Anthony - Copy could be: Your download will be cancelled if it is not complete before you end your private browsing session. Resume download | Cancel download

LMK if you care to chat.

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to mheubusch from comment #4)
> Hi Anthony - Copy could be: Your download will be cancelled if it is not
> complete before you end your private browsing session. Resume download |
> Cancel download

WFM! We could even leave it as "Resume | Cancel" since download is contextual here.

Sebastian?

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Anthony Lam (:antlam) from comment #5)
> (In reply to mheubusch from comment #4)
> > Hi Anthony - Copy could be: Your download will be cancelled if it is not
> > complete before you end your private browsing session. Resume download |
> > Cancel download
> 
> WFM! We could even leave it as "Resume | Cancel" since download is
> contextual here.
> 
> Sebastian?

If Michelle is OK with it :) 

I'm mostly concerned about localization and UI spacing

Comment 7

[mheubusch]

Could there be any confusion about what you are resuming or canceling?  I was concerned that someone might think they were cancelling closing out of the browsing session so they could continue to download.  If that is not an issue, then it is fine to shorten to Resume | Cancel  

FWIW, I think it is less of a problem (ie their privacy is more intact) if someone accidentally stops a download when they meant to return to browsing than vice versa.

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to mheubusch from comment #7)
> FWIW, I think it is less of a problem (ie their privacy is more intact) if
> someone accidentally stops a download when they meant to return to browsing
> than vice versa.

This is a good point too.

Perhaps we should implement this simple dialog for the time being (with the copy as is) and think about this some more when we have some time and/or do some testing.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Anthony Lam (:antlam) from comment #5)
> (In reply to mheubusch from comment #4)
> > Hi Anthony - Copy could be: Your download will be cancelled if it is not
> > complete before you end your private browsing session. Resume download |
> > Cancel download
> 
> WFM! We could even leave it as "Resume | Cancel" since download is
> contextual here.
> 
> Sebastian?

Isn't "Resume" a bit misleading because the download is not paused/cancelled yet and still running? Or is the idea here that we stop the download like we do now and then ask whether it should be resumed? What I mean is: The download is either running or stopped when we show the dialog: This means one of the options will do actually nothing.

However technically we will need to check whether we can continue the download *without* closing the last private tab or whether we will have to prevent the user form closing the last tab. This is something an engineer can already figure out.

Comment 10

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Talking about this more in person. There seems to be inherently a lot of issues with Downloads. Let's take a step back and look at the big picture before making changes here.

Comment 11

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.