Fix hanging indent of child twisty in jit-optimizations-view and RTL locales

VERIFIED FIXED in Firefox 52

Status

P2
normal
VERIFIED FIXED
2 years ago
5 months ago

People

(Reporter: magicp.jp, Assigned: Towkir, Mentored)

Tracking

(Blocks: 2 bugs, {good-first-bug})

Trunk
Firefox 52
good-first-bug
Dependency tree / graph

Firefox Tracking Flags

(firefox51 unaffected, firefox52 verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8783378 [details]
fix-hanging-indent-of-child-twisty-in-jit-optimizations-view-and-rtl.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160821030226

Steps to reproduce:

1. Start Nightly in RTL locales (e.g. Arabic)
2. Go to "http://helloracer.com/webgl/"
3. Open DevTools > Performance
4. Start Recording and stop
5. Select any rows that include (i) info mark
6. Open twisty in jit-optimizations-view
7. Check hanging indent of child twisty


Actual results:

Child twisty don't have hanging indent.


Expected results:

Fix hanging indent of child twisty in jit-optimizations-view and RTL locales
(Reporter)

Comment 1

2 years ago
>4. Start Recording and stop
+ Select "Call Tree" view
>5. Select any rows that include (i) info mark
Has STR: --- → yes
status-firefox51: --- → affected
Component: Untriaged → Developer Tools: Performance Tools (Profiler/Timeline)
OS: Unspecified → All
Hardware: Unspecified → All
(Reporter)

Updated

2 years ago
Blocks: 1216762
Blocks: 1145697
Priority: -- → P2
Blocks: 1143804
No longer blocks: 1145697
You need to replace marginLeft with marginInlineStart here:
https://dxr.mozilla.org/mozilla-central/source/devtools/client/performance/components/jit-optimizations-item.js#167

Towkir, are you interested in this bug?
Mentor: ntim.bugs
Flags: needinfo?(3ugzilla)
Keywords: good-first-bug
(Assignee)

Comment 3

2 years ago
Created attachment 8800926 [details] [diff] [review]
child_twisty_indentation.patch

Thanks again Tim, Hope this works :)
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Flags: needinfo?(3ugzilla)
Attachment #8800926 - Flags: review?(ntim.bugs)
Comment on attachment 8800926 [details] [diff] [review]
child_twisty_indentation.patch

Looks good to me, thanks!
Attachment #8800926 - Flags: review?(ntim.bugs) → review+
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/e412b386433b
Fix indentation of child twisty in jit-optimizations-view in RTL locales. r=ntim
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e412b386433b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
(Reporter)

Comment 7

2 years ago
Created attachment 8802946 [details]
verified-in-52.png

verified in latest Nightly build(20161019030208). Thanks!
How about uplift to Aurora?
(Reporter)

Updated

2 years ago
status-firefox52: fixed → verified
(In reply to magicp from comment #7)
> Created attachment 8802946 [details]
> verified-in-52.png
> 
> verified in latest Nightly build(20161019030208). Thanks!
Thanks for the verification!

> How about uplift to Aurora?
The feature is disabled by default on Aurora (and it can only be enabled from about:config), so I don't see much value in uplifting.
Status: RESOLVED → VERIFIED
(Reporter)

Updated

2 years ago
status-firefox51: affected → unaffected

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.