Closed Bug 1296984 Opened 5 years ago Closed 5 years ago
Fix hanging indent of child twisty in jit-optimizations-view and RTL locales
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 Build ID: 20160821030226 Steps to reproduce: 1. Start Nightly in RTL locales (e.g. Arabic) 2. Go to "http://helloracer.com/webgl/" 3. Open DevTools > Performance 4. Start Recording and stop 5. Select any rows that include (i) info mark 6. Open twisty in jit-optimizations-view 7. Check hanging indent of child twisty Actual results: Child twisty don't have hanging indent. Expected results: Fix hanging indent of child twisty in jit-optimizations-view and RTL locales
>4. Start Recording and stop + Select "Call Tree" view >5. Select any rows that include (i) info mark
You need to replace marginLeft with marginInlineStart here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/performance/components/jit-optimizations-item.js#167 Towkir, are you interested in this bug?
Thanks again Tim, Hope this works :)
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Attachment #8800926 - Flags: review?(ntim.bugs)
Comment on attachment 8800926 [details] [diff] [review] child_twisty_indentation.patch Looks good to me, thanks!
Attachment #8800926 - Flags: review?(ntim.bugs) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/fx-team/rev/e412b386433b Fix indentation of child twisty in jit-optimizations-view in RTL locales. r=ntim
verified in latest Nightly build(20161019030208). Thanks! How about uplift to Aurora?
(In reply to magicp from comment #7) > Created attachment 8802946 [details] > verified-in-52.png > > verified in latest Nightly build(20161019030208). Thanks! Thanks for the verification! > How about uplift to Aurora? The feature is disabled by default on Aurora (and it can only be enabled from about:config), so I don't see much value in uplifting.
You need to log in before you can comment on or make changes to this bug.