1297018 - Download notification is not displayed in the android notification bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect, P1)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open a website
2. Go to Menu -> Page -> Save as PDF 

Expected results:
- A download notification is displayed in the android notification bar

Actual results:
- no download notification is displayed 
- download appears in about:download

Note:
- regression window:
good build: 17-08
bad build: 18-08
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fe895421dfbe1f1f8f1fc6a39bb20774423a6d74&tochange=97a52326b06a07930216ebefa5af333271578904

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #0)
> Steps to reproduce:
> 1. Open a website
> 2. Go to Menu -> Page -> Save as PDF 

To clarify: All downloads are affected. Not only "Save as PDF".

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

bisect says:

> The first bad revision is:
> changeset:   309691:5f9021b0c901
> user:        Shih-Chiang Chien <[e-mail]>
> date:        Fri Jun 03 19:50:30 2016 +0800
> summary:     Bug 1278205 - use preference for exposing presentation API. r=smaug.

I don't know why this broke all our download notifications / events yet, though.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

I just verified with a local backout that this is indeed the breaking changeset.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Changeset: https://hg.mozilla.org/mozilla-central/rev/5f9021b0c901

Comment 5

[Andrzej Hunt :ahunt]

I'm seeing this in the console, which looks related - and I've seen multiple things break when there's just one JS error in the past:
TypeError: window.navigator.mozPresentationDeviceInfo is undefined - CastingApps.js:102:5

Comment 6

[Andrzej Hunt :ahunt]

Attachment: Bug 1297018 - Reenable dom.presentation.enabled on Android

This appears to fix the download notifications on Android. Disabling the presentation API
causes errors in our Casting code, and that (for currently not understood reasons)
seems to disable download notifications.

Review commit: https://reviewboard.mozilla.org/r/73462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73462/

Comment 7

[Andrzej Hunt :ahunt]

The patch I've posted is enough to fix our problems - however I don't have any understanding of:

A) why the presentation WebAPI was disabled for mobile in Bug 1278205?
B) if/how we should fix the Casting code to handle the presentation WebAPI being disabled?

Comment 8

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

My bad, I'll upload a fix for the solution B mentioned in comment #7.

Comment 9

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

(In reply to Andrzej Hunt :ahunt from comment #7)
> A) why the presentation WebAPI was disabled for mobile in Bug 1278205?

Here is the reason I disable Presentation API in Bug 1278205
1) Presentation API is not yet ready to be exposed to web content.
2) The availability of TV that supports video casting via Presentation API is unknown at this point, so we can disable this API for browser chrome as well.

Comment 10

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 1297018 - disable video casting to FxOS TV while presentation API is not supported. .

Review commit: https://reviewboard.mozilla.org/r/73470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73470/

Comment 11

[Andrzej Hunt :ahunt]

Comment on attachment 8783789 [details]
Bug 1297018 - disable video casting to FxOS TV while presentation API is not supported. .

https://reviewboard.mozilla.org/r/73470/#review71724

Thank you for looking into this : ) !

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54caa97ec316
disable video casting to FxOS TV while presentation API is not supported. r=ahunt.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54caa97ec316

Comment 14

[Alex Caziuc]

Verified as fixed with Samsung Galaxy Note 5(6.0.1) on Nightly(2016-08-31)