Remove decommit threshold

RESOLVED FIXED in Firefox 51

Status

()

Core
JavaScript: GC
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jonco, Assigned: terrence)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Since we now decommit at the end of every GC, we don't need to have a decommit threshold any more.  Originally this would have been used to trigger periodic full GCs but these also got removed in bug 1296639.
(Assignee)

Comment 2

2 years ago
Created attachment 8783716 [details] [diff] [review]
remove_decommit_threshold-v0.diff

I had forgotten that we even made it tweakable.
Assignee: jcoppeard → terrence
Status: NEW → ASSIGNED
Attachment #8783716 - Flags: review?(jcoppeard)
(Reporter)

Comment 3

2 years ago
Comment on attachment 8783716 [details] [diff] [review]
remove_decommit_threshold-v0.diff

Review of attachment 8783716 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for doing this.
Attachment #8783716 - Flags: review?(jcoppeard) → review+
(Reporter)

Comment 4

2 years ago
Created attachment 8783894 [details] [diff] [review]
bug1297067-remove-decommit-threshold-2

Patch to remove preference settings for javascript.options.mem.gc_decommit_threshold_mb which is going away.
Attachment #8783894 - Flags: review?(bkelly)
(Assignee)

Comment 5

2 years ago
Comment on attachment 8783894 [details] [diff] [review]
bug1297067-remove-decommit-threshold-2

Review of attachment 8783894 [details] [diff] [review]:
-----------------------------------------------------------------

Knew I missed something!

Stealing review: I'm like 99% sure that I added those lines in the first place.
Attachment #8783894 - Flags: review?(bkelly) → review+

Comment 6

2 years ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3886cf2509a7
Remove unused decommit threshold r=jonco

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3886cf2509a7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.