Closed Bug 1297075 Opened 3 years ago Closed 3 years ago

[Static Analysis][Uninitialized scalar variable] In constructor MaybeInvalidTabContext::MaybeInvalidTabContext

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1368330, CID 1368329)

Attachments

(1 file)

The Static Analysis tool Coverity detected that variables |showAccelerators| and |showFocusRings| could be uninitialised when calling:


>>  bool rv;
>>  rv = mTabContext.SetTabContext(isMozBrowserElement,
>>                                 isPrerendered,
>>                                 ownApp,
>>                                 containingApp,
>>                                 showAccelerators,
>>                                 showFocusRings,
>>                                 originAttributes,
>>                                 signedPkgOriginNoSuffix,
>>                                 presentationURL);

This could be the case only if type |aParams| is different than IPCTabContext::TFrameIPCTabContext
Attachment #8783551 - Flags: review?(peterv) → review?(amarchesini)
Comment on attachment 8783551 [details]
Bug 1297075 - initialise with default value showAccelerators| and |showFocusRings|.

https://reviewboard.mozilla.org/r/73332/#review75432
Attachment #8783551 - Flags: review?(amarchesini) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b84791fdddb2
initialise with default value showAccelerators| and |showFocusRings|. r=baku
https://hg.mozilla.org/mozilla-central/rev/b84791fdddb2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.