129708 - Multibyte base DN is dislayed garbled, unable to connect

Status: VERIFIED FIXED

(MailNews Core :: LDAP Integration, defect, P2)

Description

[ji]

Build: 03/08 win32

Ja base DN is displayed garbled on Edit window, unable to connect to the
directory with this base DN.

Steps to reproduce:
1. Open Edit | Preferences | Mail and Newsgroup | Addressing window.
2. Check on Directory Server.
3. Click on Edit Directories
4. Click on Add.
5. Enter a directory name and a mutibyte base DN like o=ネットスケープ, port set
to 8000, and click on OK button to save it. (view this page in Japanese
(Shift-JIS), and copy/paset the Ja base DN)
6. Select the newly created directory with the ja base DN and click on Edit,
   the Ja base DN is not displayed correctly.

Screenshot to follow.

Comment 1

[ji]

This is a serious regression from NS6.2.1, nominating for nsbeta1.

Comment 2

[ji]

Attachment: A screenshot.

Comment 3

[Srilatha Moturi]

This will be fixed by my patch in bug 124059

Comment 4

[Michael Buckland]

Discussed in Mail News bug meeting.  Decided to ADT2 this bug.

Comment 5

[Frank Tang]

ji:
when will user put non ascii DN ? is this a common requirement for non ASCII
enterprise market ?

Comment 6

[Frank Tang]

the patch in 124059 seems quite big. Is that possible we can produce a smaller
patch for THIS BUG and propose to be fixed earler than 124059 ?

Comment 7

[ji]

If the directory instance is created with a non-ASCII base DN, the client has to
provide this feature to be able to connect to this type of directory instances.
Base DN is the root of directory instance, it's very possible to have a
non-ASCII base DN if the company's name is non-ASCII. When I tested Directory
Server at Server team, supporting non-ASCII base DN is a requirement for
Directory Server.

Comment 8

[Srilatha Moturi]

Attachment: patch v1

changed the code such that we use getComplexValue and setComplexValue while
reading and writing the uri pref. Probably we will have to do the same for Ldap
pref migration code. Shirley is testing if that is broken too.

Comment 9

[ji]

Yes, 4.x pref migration is also broken. Tested with 04/10 trunk build and 4.75 Ja.

Comment 10

[Srilatha Moturi]

Attachment: patch v2 (includes fix for migration)

Comment 11

[Jean-Francois Ducarroz]

Comment on attachment 78597 [details] [diff] [review]
patch v2 (includes fix for migration)

R=ducarroz

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 78597 [details] [diff] [review]
patch v2 (includes fix for migration)

sr=sspitzer

Comment 13

[Srilatha Moturi]

Fix checked into the trunk.

Comment 14

[yulian chang]

Reassign QA Contact to [e-mail]

Comment 15

[scottputterman]

After this has been tested on the trunk, please update the bug.

Comment 16

[ji]

Verified on 04/16 and 04/17 trunk builds. Both search and migration problems
using double-byte base DN are fixed on the trunk.

Comment 17

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADTs behalf) approval for checkin to 1.0 branch. Pls check this
into the 1.0 branch and trunk today. After, this has landed on the branch, pls
add the fixed1.0.0 keyword.

Comment 18

[Srilatha Moturi]

Fix was checked into the trunk on 4/15

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 78597 [details] [diff] [review]
patch v2 (includes fix for migration)

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 20

[Srilatha Moturi]

Fix checked into the branch.

Comment 21

[ji]

Verified with 04/19 branch builds.

Comment 22

[nhottanscp]

*** Bug 138618 has been marked as a duplicate of this bug. ***

Comment 23

[ji]

Removed fixed1.0.0 keyword since I already verified on the branch and added
verified1.0.0 keyword.