Closed Bug 1297127 Opened 3 years ago Closed 3 years ago

Move AS panel back into HomePager

Categories

(Firefox for Android :: Awesomescreen, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Iteration:
1.3
Tracking Status
firefox51 --- fixed

People

(Reporter: ahunt, Assigned: ahunt)

Details

(Whiteboard: [MobileAS])

Attachments

(3 files)

The Activity Stream panel was originally built as a replacement of the HomePager. For now we want to use it as a replacement of the TopSites panel.

We want to keep the infrastructure for switching the entire HomePager (since that's likely what we'll need in future), but disabled. The preference should instead switch between the TopSites and AS panel within the HomePager.
Assignee: nobody → ahunt
Whiteboard: [MobileAS]
Priority: -- → P2
Priority: P2 → P1
Comment on attachment 8786121 [details]
Bug 1297127 - show ActivityStream as a HomePanel, replacing TopSites

https://reviewboard.mozilla.org/r/75082/#review72952

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStreamHomeFragment.java:1
(Diff revision 1)
> +/* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-

I need to add this to moz.build (again)!

(Maybe I should look into making a mercurial hook to check this?)
Comment on attachment 8786119 [details]
Bug 1297127 - Move HomeScreen specific code into ActivityStreamHomeScreen

https://reviewboard.mozilla.org/r/75078/#review73138
Attachment #8786119 - Flags: review?(s.kaspari) → review+
Comment on attachment 8786120 [details]
Bug 1297127 - add ActivityStream.isHomePanel() fake-pref for switching from HomeScreen to HomePanel

https://reviewboard.mozilla.org/r/75080/#review73140
Attachment #8786120 - Flags: review?(s.kaspari) → review+
Comment on attachment 8786120 [details]
Bug 1297127 - add ActivityStream.isHomePanel() fake-pref for switching from HomeScreen to HomePanel

https://reviewboard.mozilla.org/r/75080/#review73142

::: mobile/android/base/java/org/mozilla/gecko/activitystream/ActivityStream.java:25
(Diff revision 1)
>          return GeckoSharedPrefs.forApp(context)
>                  .getBoolean(GeckoPreferences.PREFS_ACTIVITY_STREAM, false);
>      }
> +
> +    /**
> +     * Query whether we want to display Activity Stream as a Home Panel (within the Home Panel),

"as home panel within the home panel"?
Comment on attachment 8786121 [details]
Bug 1297127 - show ActivityStream as a HomePanel, replacing TopSites

https://reviewboard.mozilla.org/r/75082/#review73144
Attachment #8786121 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/6e90012149228a56cd0d34ffd0f566b4b963d0e8
Bug 1297127 - Move HomeScreen specific code into ActivityStreamHomeScreen r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/5ceeeb443a5c096ef72c833bf97230017ca1bfac
Bug 1297127 - add ActivityStream.isHomePanel() fake-pref for switching from HomeScreen to HomePanel r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/0066d2c20597326c4d7314f7e9cfac52beefae9f
Bug 1297127 - show ActivityStream as a HomePanel, replacing TopSites r=sebastian
Iteration: --- → 1.3
You need to log in before you can comment on or make changes to this bug.