1297138 - Signature for nsICookieManager.remove() changed

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[arlolra]

Attachment: 0001-Signature-for-nsICookieManager.remove-changed.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce:

Tried to add a new account


Actual results:

“oauthcallback.local could not be found” error

Even with this patch, I still can't sign in ... but that looks like a problem with the js twitter is serving.  Not sure.

Comment 1

[Patrick Cloke [:clokep]]

See bug 1282100 also.

Did you want to have this reviewed?

Comment 2

[arlolra]

>  See bug 1282100 also.

Oh, sorry, this is a dup.  Should I move the patch there?


> Did you want to have this reviewed?

Yes please.  Wasn't sure who to ask.

Comment 4

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/de70f69c6d2b2582fae8fbe8ac69a51db067d51d
Bug 1297138 - Signature for nsICookieManager.remove() changed. r=clokep

Comment 5

[aleth [:aleth]]

(In reply to arlolra from comment #0)
> Even with this patch, I still can't sign in ... but that looks like a
> problem with the js twitter is serving.  Not sure.

Is there a bug for this somewhere?

Comment 6

[arlolra]

Thanks for the quick merge.

> Is there a bug for this somewhere?

The problem was that my test account was flagged as a bot and needed verification.

When I used another account in good standing, all went well.

Comment 7

[aleth [:aleth]]

Comment on attachment 8783629 [details] [diff] [review]
0001-Signature-for-nsICookieManager.remove-changed.patch

[Approval Request Comment]
Regression caused by (bug #): First seen on 24-6, so we need this in TB 50.

Comment 8

[Jorg K (CEST = GMT+2)]

Sorry, I completed the uplifts for TB 50 beta on 2016-10-16 21:36 CEST and didn't check any more after that. So this missed the boat.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8783629 [details] [diff] [review]
0001-Signature-for-nsICookieManager.remove-changed.patch

Beta (TB 50):
https://hg.mozilla.org/releases/comm-beta/rev/8f10f52f195829c856757ebb094fe9fbabe639eb

There might be another beta, so I uplifted this.