Closed Bug 1297202 Opened 8 years ago Closed 8 years ago

Cross-namespace submodule reference in a schema is not resolved

Categories

(WebExtensions :: Untriaged, defect)

51 Branch
defect
Not set
normal

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: robwu, Assigned: robwu)

Details

Attachments

(1 file)

If, say, an experimental API wants to reference an existing submodule type, e.g. storage.StorageArea, then it fails because cross-namespace references are not supported.

The lack of support was fine so far because we don't use cross-namespace submodule references, but with experimental APIs this should be supported because all other $refs are correctly resolved.
Comment on attachment 8783722 [details]
Bug 1297202 - Support cross-namespace submodule references in schemas

https://reviewboard.mozilla.org/r/73414/#review71230
Attachment #8783722 - Flags: review?(aswan) → review+
About the red tests on https://treeherder.mozilla.org/#/jobs?repo=try&revision=485caa205d58&selectedJob=26160699, that's because I added the "--tag webextensions" flag to the try command, so some jobs did not find any matching tests. Locally I've already verified that the new test passes with the change (and fails without).
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/998b7d53a1f8
Support cross-namespace submodule references in schemas r=aswan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/998b7d53a1f8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: