Experiments APIs don't get schema wrappers

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
WebExtensions: Experiments
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aswan, Assigned: aswan)

Tracking

51 Branch
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The summary pretty much says it all.
Comment hidden (mozreview-request)
Comment on attachment 8783754 [details]
Bug 1297229 Run experiments APIs through schemas

https://reviewboard.mozilla.org/r/73438/#review71464

::: toolkit/components/extensions/test/xpcshell/test_ext_experiments.js:92
(Diff revision 1)
> +      // The test code below checks that hello() is called at the right
> +      // time with the string "Here I am".  Verify that the api schema is
> +      // being correctly interpreted by calling hello() with bad arguments
> +      // and only calling hello() with the magic string if the call with
> +      // bad arguments throws.
> +      try {
> +        browser.meh.hello("I should not see this", "since two arguments are bad");
> +      } catch (err) {
> -      browser.meh.hello("Here I am");
> +        browser.meh.hello("Here I am");
> +      }

Would be nice to test the promise/callback wrappers too.

::: toolkit/components/extensions/test/xpcshell/test_ext_simple.js:63
(Diff revision 1)
> +    manifest: {
> +      "name": "Simple extension test",
> +      "version": "1.0",
> +      "manifest_version": 2,
> +      "description": "",
> +    },

Shouldn't need any of this.
Attachment #8783754 - Flags: review?(kmaglione+bmo) → review+
(Assignee)

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8783754 [details]
Bug 1297229 Run experiments APIs through schemas

https://reviewboard.mozilla.org/r/73438/#review71464

> Would be nice to test the promise/callback wrappers too.

My logic here is that this tests that the schema wrappers actually do get applied, and testing that the schema async wrappers work properly is really the job of the schema wrapper unit tests.
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/abf8b6e8ebed
Run experiments APIs through schemas r=kmag

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/abf8b6e8ebed
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.