1297343 - Make some more object classes background finalized

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: make-more-things-bg-finalized

Following the previous finalization changes, here's a patch to make some more things background finalized.

For foreground finalized things I also added and assertion to the finalizer that it's called on the main thread.  Sometimes background finalized things can be finalized on the main thread too so we can't add the opposite assert for them.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8783901 [details] [diff] [review]
make-more-things-bg-finalized

Review of attachment 8783901 [details] [diff] [review]:
-----------------------------------------------------------------

We could add a state variable saying that we're doing bg finalization, just to assert on it regardless of which thread we're actually running on. You'd have a better idea than I would as to whether it'd be worth it; I'm fine landing this as-is.

::: js/src/vm/SharedArrayObject.cpp
@@ +300,5 @@
>  
>  void
>  SharedArrayBufferObject::Finalize(FreeOp* fop, JSObject* obj)
>  {
> +    // Note: This can be executed off main thread.

This is the only scary one, but I think you're right, it looks safe.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: finalize-updates

Oh, we can just ensure that the runtime pointer is always null when we do background finalization regardless of thread.  Then we can add a maybeOffMainThread() method that we can check with assertions.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: make-more-things-bg-finalized v2

I replaced the comments for finalizers called in the background with assertions on fop->maybeOffMainThread().  Carrying r+.

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8784352 [details] [diff] [review]
finalize-updates

Review of attachment 8784352 [details] [diff] [review]:
-----------------------------------------------------------------

I like it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9be45967d42c
Make some more object classes background finalized r=sfink

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9be45967d42c