1297368 - Import nsIUserCertPicker and nsICertPickDialogs related code removed from m-c in Bug 1142350

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[:Cykesiopka]

Bug 1142350 will remove from m-c the unused nsIUserCertPicker, nsICertPickDialogs, and associated code only used by the implementations of those interfaces.

This code *is* used in c-c however, so this bug will track importing the removed code to keep S/MIME cert selection working.

Comment 1

[:Cykesiopka]

Attachment: bug1297368_part1a_cp-standalone-files_v1.patch

This patch imports the initial batch of nsIUserCertPicker and nsICertPickDialogs related code removed from m-c.

The code is directly copied from m-c with at most trivial changes, and trailing
spaces removed.

Comment 2

[:Cykesiopka]

Attachment: bug1297368_part1b_cp-non-standalone-code_v1.patch

This patch imports the rest of code removed from m-c to c-c.

The code is directly copied from m-c with at most trivial changes, and trailing
spaces removed.

Comment 3

[:Cykesiopka]

Attachment: bug1297368_part2_hook-up-code_v1.patch

This patch makes the imported code from the previous patches actually build and work.

Comment 4

[:Cykesiopka]

I've separated the changes required to get things working again into three patches for easier review.
I'll fold the changes into a single patch before getting it checked in.

jcranmer: I only tested the changes by manually testing on Thunderbird and SeaMonkey that the Account Security > Security cert pickers still work. If there are other tests I should run, please let me know.

Comment 5

[Kent James (:rkent)]

Comment on attachment 8793285 [details] [diff] [review]
bug1297368_part1a_cp-standalone-files_v1.patch

Thanks so much for doing this! If jcranmer does not get to this soon, I'll have a look at it (and the other patches).

Comment 6

[Kent James (:rkent)]

Comment on attachment 8793285 [details] [diff] [review]
bug1297368_part1a_cp-standalone-files_v1.patch

Review of attachment 8793285 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested this compiles and builds, and confirmed that the certificate picker still works. I also looked this over and did not see any obvious issues, so let's land it after the dependent patch lands.

Comment 7

[:Cykesiopka]

Attachment: bug1297368_import-cert-picker-to-c-c_v1.patch

Parts 1a, 1b and 2 folded together.

Comment 8

[:Cykesiopka]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=23cb93e8a78ca4ddf743cb2b07c34cf014993194

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/8f03509765dafb5be8183ba6e72f98f85f7c3099