Closed Bug 1297368 Opened 3 years ago Closed 3 years ago

Import nsIUserCertPicker and nsICertPickDialogs related code removed from m-c in Bug 1142350

Categories

(MailNews Core :: Security: S/MIME, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

Details

Attachments

(1 file, 3 obsolete files)

Bug 1142350 will remove from m-c the unused nsIUserCertPicker, nsICertPickDialogs, and associated code only used by the implementations of those interfaces.

This code *is* used in c-c however, so this bug will track importing the removed code to keep S/MIME cert selection working.
This patch imports the initial batch of nsIUserCertPicker and nsICertPickDialogs related code removed from m-c.

The code is directly copied from m-c with at most trivial changes, and trailing
spaces removed.
Attachment #8793285 - Flags: review?(Pidgeot18)
This patch imports the rest of code removed from m-c to c-c.

The code is directly copied from m-c with at most trivial changes, and trailing
spaces removed.
Attachment #8793286 - Flags: review?(Pidgeot18)
This patch makes the imported code from the previous patches actually build and work.
Attachment #8793287 - Flags: review?(Pidgeot18)
I've separated the changes required to get things working again into three patches for easier review.
I'll fold the changes into a single patch before getting it checked in.

jcranmer: I only tested the changes by manually testing on Thunderbird and SeaMonkey that the Account Security > Security cert pickers still work. If there are other tests I should run, please let me know.
Comment on attachment 8793285 [details] [diff] [review]
bug1297368_part1a_cp-standalone-files_v1.patch

Thanks so much for doing this! If jcranmer does not get to this soon, I'll have a look at it (and the other patches).
Attachment #8793285 - Flags: review?(rkent)
Comment on attachment 8793285 [details] [diff] [review]
bug1297368_part1a_cp-standalone-files_v1.patch

Review of attachment 8793285 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested this compiles and builds, and confirmed that the certificate picker still works. I also looked this over and did not see any obvious issues, so let's land it after the dependent patch lands.
Attachment #8793285 - Flags: review?(rkent)
Attachment #8793285 - Flags: review?(Pidgeot18)
Attachment #8793285 - Flags: review+
Attachment #8793286 - Flags: review?(Pidgeot18) → review+
Attachment #8793287 - Flags: review?(Pidgeot18) → review+
Parts 1a, 1b and 2 folded together.
Attachment #8793285 - Attachment is obsolete: true
Attachment #8793286 - Attachment is obsolete: true
Attachment #8793287 - Attachment is obsolete: true
Attachment #8797895 - Flags: review+
https://hg.mozilla.org/comm-central/rev/8f03509765dafb5be8183ba6e72f98f85f7c3099
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.