Reftest jobs on OSX don't generate structuredlog artifacts

RESOLVED FIXED in Firefox 51

Status

Testing
Reftest
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

Version 3
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I noticed that the configs to get reftests to output a reftest_raw.log to the blobber/artifact dir is missing. This means active data is not ingesting reftest results on OSX.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8783953 [details]
Bug 1297377 - Reftests on OSX should generate and upload a structured log artifact,

https://reviewboard.mozilla.org/r/73578/#review71406

::: testing/mozharness/configs/unittests/mac_unittest.py:117
(Diff revision 1)
>          "reftest": {
>              "options": [
>                  "--appname=%(binary_path)s",
>                  "--utility-path=tests/bin",
>                  "--extra-profile-file=tests/bin/plugins",
> -                "--symbols-path=%(symbols_path)s"
> +                "--symbols-path=%(symbols_path)s",

I wonder if this missing comma meant that the symbols-path was garbage and therefore crash reporting has been broken all this time :/

Comment 3

2 years ago
mozreview-review
Comment on attachment 8783953 [details]
Bug 1297377 - Reftests on OSX should generate and upload a structured log artifact,

https://reviewboard.mozilla.org/r/73578/#review71410

I assume you tried this.

And yeah, gah at missing comma.
Attachment #8783953 - Flags: review?(james) → review+
(Assignee)

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8783953 [details]
Bug 1297377 - Reftests on OSX should generate and upload a structured log artifact,

https://reviewboard.mozilla.org/r/73578/#review71410

For posterity, this change was tested in this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3abf6cb08b972ba70af6f0941f0d6e2d2bfda7d

Comment 5

2 years ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/127f2f410e93
Reftests on OSX should generate and upload a structured log artifact, r=jgraham
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> I wonder if this missing comma meant that the symbols-path was garbage and
> therefore crash reporting has been broken all this time :/

Do you mean like bug 1281232 comment 1?  (I probably should have filed a bug on that yesterday...)
Yeah, seems likely that's related. Should be fixed now, but I'll keep an eye out for an osx crash and verify the stack is useful.

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/127f2f410e93
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.